games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-12-03 23:19:22 +02:00
Code Issues Releases Activity

Show (mostly) correct messages in Shrines

Browse Source
This commit is contained in:
Ivan Savenko
2023-10-16 17:55:31 +03:00
parent 0ea44520fd
commit 850d0ff8eb
7 changed files with 100 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/JsonNode.cpp
View File

@@ -822,10 +822,7 @@ std::shared_ptr<Bonus> JsonUtils::parseBonus(const JsonNode &ability)
{
// caller code can not handle this case and presumes that returned bonus is always valid
logGlobal->error("Failed to parse bonus! Json config was %S ", ability.toJson());
b->type = BonusType::NONE;
assert(0); // or throw? Game *should* work with dummy bonus
return b;
}
return b;