games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-01-26 03:52:01 +02:00
Code Issues Releases Activity

Likely fixed duplicated random heroes

Browse Source
This commit is contained in:
Ivan Savenko 2015-12-05 01:40:23 +02:00
parent 8a3feb1e48
commit 89bf3592e3
2 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/CGameState.cpp
View File

@ -1383,7 +1383,8 @@ void CGameState::placeStartingHeroes()
} }
int heroTypeId = pickNextHeroType(playerColor); int heroTypeId = pickNextHeroType(playerColor);
if(playerSettingPair.second.hero == -1) playerSettingPair.second.hero = heroTypeId; if(playerSettingPair.second.hero == -1)
playerSettingPair.second.hero = heroTypeId;
placeStartingHero(playerColor, HeroTypeID(heroTypeId), playerInfo.posOfMainTown); placeStartingHero(playerColor, HeroTypeID(heroTypeId), playerInfo.posOfMainTown);
} }
@ -2770,7 +2771,7 @@ CGHeroInstance * CGameState::getUsedHero(HeroTypeID hid) const
{ {
for(auto hero : map->heroesOnMap) //heroes instances initialization for(auto hero : map->heroesOnMap) //heroes instances initialization
{ {
if(hero->subID == hid.getNum()) if(hero->type && hero->type->ID == hid)
{ {
return hero; return hero;
} }
@ -2778,9 +2779,12 @@ CGHeroInstance * CGameState::getUsedHero(HeroTypeID hid) const
for(auto obj : map->objects) //prisons for(auto obj : map->objects) //prisons
{ {
if(obj && obj->ID == Obj::PRISON && obj->subID == hid.getNum()) if(obj && obj->ID == Obj::PRISON )
{ {
return dynamic_cast<CGHeroInstance *>(obj.get()); auto hero = dynamic_cast<CGHeroInstance *>(obj.get());
assert(hero);
if ( hero->type && hero->type->ID == hid )
return hero;
} }
} }