games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-08-13 19:54:17 +02:00
Code Issues Releases Activity

Merge pull request #679 from ShubusCorporation/do/fix/mod_resolving_typo

Browse Source 
Fix: Error in mods resolving routine
This commit is contained in:
Alexander Shishkin
2021-02-10 01:39:47 +03:00
committed by GitHub
parent db1f9a15b0 2afdd4ed4c
commit 8e1a3924e7
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/CModHandler.cpp
View File

@@ -725,8 +725,11 @@ std::vector <TModID> CModHandler::resolveDependencies(std::vector <TModID> modsT
auto res = true; auto res = true;
for(const TModID & dependency : mod.dependencies) for(const TModID & dependency : mod.dependencies)
{ {
if(!(res = vstd::contains(modsToResolve, dependency))) if(!vstd::contains(modsToResolve, dependency))
{
logMod->error("Mod '%s' will not work: it depends on mod '%s', which is not installed.", mod.name, dependency); logMod->error("Mod '%s' will not work: it depends on mod '%s', which is not installed.", mod.name, dependency);
res = false; //continue iterations, since we should show all errors for the current mod.
}
} }
return res; return res;
}; };