games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-11-25 22:42:04 +02:00
Code Issues Releases Activity

fix: time-of-check-to-time-of-use (TOCTOU) race condition in AIMemory::removeInvisibleObjects; a bit of refactoring in RecruitHeroBehavior and some todo comments for later on

Browse Source
This commit is contained in:
Mircea TheHonestCTO
2025-09-25 17:09:42 +02:00
parent 46668f7b23
commit a836cd3aed
18 changed files with 153 additions and 114 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
AI/Nullkiller2/Engine/FuzzyHelper.cpp
View File

@@ -144,7 +144,7 @@ ui64 FuzzyHelper::evaluateDanger(const CGObjectInstance * obj)
case Obj::ARTIFACT:
case Obj::RESOURCE:
{
if(!vstd::contains(aiNk->memory->alreadyVisited, obj))
if(!vstd::contains(aiNk->memory->alreadyVisited, obj->id))
return 0;
[[fallthrough]];
}