1
0
mirror of https://github.com/vcmi/vcmi.git synced 2025-11-27 22:49:25 +02:00

Warnings fixes (#538)

Warnings fixes
* Suppress `missing-braces` for Clang
* Fixed many C4275 warnings
* Fixed almost all Clang/GCC warnings
* Silence most frequent MSVC warning.
* Fixed some pessimizing-move warnings
* Fixed some unused capture warnings
This commit is contained in:
Alexander Shishkin
2019-01-19 13:52:02 +03:00
committed by GitHub
parent 419fee1fb2
commit b00e935e4d
34 changed files with 67 additions and 71 deletions

View File

@@ -789,12 +789,13 @@ void processCommand(const std::string &message)
}
else if(cn == "gui")
{
for(auto child : GH.listInt)
for(auto & child : GH.listInt)
{
if(const CIntObject *obj = dynamic_cast<const CIntObject *>(child.get()))
const auto childPtr = child.get();
if(const CIntObject * obj = dynamic_cast<const CIntObject *>(childPtr))
printInfoAboutIntObject(obj, 0);
else
std::cout << typeid(*child).name() << std::endl;
std::cout << typeid(childPtr).name() << std::endl;
}
}
else if(cn=="tell")