From b238796feebafa57716a1c7ff502f0ec0fb1c7f8 Mon Sep 17 00:00:00 2001 From: Andrii Danylchenko Date: Sun, 3 Dec 2023 20:20:59 +0200 Subject: [PATCH] MSVC: attempt to get build with pdb --- .github/workflows/github.yml | 8 ++++++++ CMakeLists.txt | 5 +++++ 2 files changed, 13 insertions(+) diff --git a/.github/workflows/github.yml b/.github/workflows/github.yml index 2e719223b..07dd4171b 100644 --- a/.github/workflows/github.yml +++ b/.github/workflows/github.yml @@ -279,6 +279,14 @@ jobs: name: ${{ env.VCMI_PACKAGE_FILE_NAME }} - ${{ matrix.platform }} path: | ${{ env.ANDROID_APK_PATH }} + + - name: Symbols + if: ${{ matrix.platform == 'msvc' }} + uses: actions/upload-artifact@v3 + with: + name: ${{ env.VCMI_PACKAGE_FILE_NAME }} - ${{ matrix.platform }} - symbols + path: | + ${{github.workspace}}/**/*.pdb - name: Android JNI ${{matrix.platform}} if: ${{ startsWith(matrix.platform, 'android') && github.ref == 'refs/heads/master' }} diff --git a/CMakeLists.txt b/CMakeLists.txt index 8a56e91fd..b502b3fbf 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -715,6 +715,11 @@ endif(WIN32) # Packaging section # ####################################### +if(MSVC) + SET(CMAKE_INSTALL_SYSTEM_RUNTIME_DESTINATION ${BIN_DIR}) + Include(InstallRequiredSystemLibraries) +endif() + set(CPACK_PACKAGE_VERSION_MAJOR ${VCMI_VERSION_MAJOR}) set(CPACK_PACKAGE_VERSION_MINOR ${VCMI_VERSION_MINOR}) set(CPACK_PACKAGE_VERSION_PATCH ${VCMI_VERSION_PATCH})