games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-07-05 00:49:09 +02:00
Code Issues Releases Activity

Reduce size of Bonus struct from 320 bytes to 296 bytes.

Browse Source 
- Internal enums were resized to occupy single byte.
- Duration bitmask uses 16 bit integer directly instead of std::bitset<11> which consumed 8 bytes.
- Fields shuffled to minimise padding and keep the most useful data on first 2 cache lines.
This commit is contained in:
K
2024-07-14 16:56:58 +02:00
parent 6f5710e809
commit c1e6bbddfe
5 changed files with 50 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/bonuses/BonusEnum.cpp
View File

@ -60,10 +60,11 @@ namespace BonusDuration
JsonNode toJson(const Type & duration)
{
std::vector<std::string> durationNames;
for(auto durBit = 0; durBit < duration.size(); durBit++)
for(size_t durBit = 0; durBit < Size; durBit++)
{
if(duration[durBit])
durationNames.push_back(vstd::findKey(bonusDurationMap, duration & Type().set(durBit)));
Type value = duration & (1 << durBit);
if(value)
durationNames.push_back(vstd::findKey(bonusDurationMap, value));
}
if(durationNames.size() == 1)
{