Removed asynchronous calls from exchange window

client/Client.h

@@ -60,9 +60,8 @@ namespace boost { class thread; }
 template<typename T>
 class ThreadSafeVector
 {
-	using TVector = std::vector<T>;
 	using TLock = boost::unique_lock<boost::mutex>;
-	TVector items;
+	std::vector<T> items;
 	boost::mutex mx;
 	boost::condition_variable cond;
 
@@ -81,28 +80,16 @@ public:
 		cond.notify_all();
 	}
 
-// 	//to access list, caller must present a lock used to lock mx
-// 	TVector &getList(TLock &lockedLock)
-// 	{
-// 		assert(lockedLock.owns_lock() && lockedLock.mutex() == &mx);
-// 		return items;
-// 	}
-
-	TLock getLock()
-	{
-		return TLock(mx);
-	}
-
 	void waitWhileContains(const T & item)
 	{
-		auto lock = getLock();
+		TLock lock(mx);
 		while(vstd::contains(items, item))
 			cond.wait(lock);
 	}
 
 	bool tryRemovingElement(const T & item) //returns false if element was not present
 	{
-		auto lock = getLock();
+		TLock lock(mx);
 		auto itr = vstd::find(items, item);
 		if(itr == items.end()) //not in container
 		{

client/windows/GUIClasses.cpp

@@ -621,51 +621,6 @@ static bool isQuickExchangeLayoutAvailable()
 	return CResourceHandler::get()->existsResource(ResourceID(std::string("SPRITES/") + QUICK_EXCHANGE_BG, EResType::IMAGE));
 }
 
-// Runs a task asynchronously with gamestate locking and waitTillRealize set to true
-class GsThread
-{
-private:
-	std::function<void()> action;
-	std::shared_ptr<CCallback> cb;
-
-public:
-
-	static void run(std::function<void()> action)
-	{
-		std::shared_ptr<GsThread> instance(new GsThread(action));
-
-
-		boost::thread(std::bind(&GsThread::staticRun, instance));
-	}
-
-private:
-	GsThread(std::function<void()> action)
-		:action(action), cb(LOCPLINT->cb)
-	{
-	}
-
-	static void staticRun(std::shared_ptr<GsThread> instance)
-	{
-		instance->run();
-	}
-
-	void run()
-	{
-		boost::shared_lock<boost::shared_mutex> gsLock(CGameState::mutex);
-
-		auto originalWaitTillRealize = cb->waitTillRealize;
-		auto originalUnlockGsWhenWating = cb->unlockGsWhenWaiting;
-
-		cb->waitTillRealize = true;
-		cb->unlockGsWhenWaiting = true;
-
-		action();
-
-		cb->waitTillRealize = originalWaitTillRealize;
-		cb->unlockGsWhenWaiting = originalUnlockGsWhenWating;
-	}
-};
-
 CExchangeController::CExchangeController(CExchangeWindow * view, ObjectInstanceID hero1, ObjectInstanceID hero2)
 	:left(LOCPLINT->cb->getHero(hero1)), right(LOCPLINT->cb->getHero(hero2)), cb(LOCPLINT->cb), view(view)
 {
@@ -696,11 +651,8 @@ std::vector<CArtifactInstance *> getBackpackArts(const CGHeroInstance * hero)
 std::function<void()> CExchangeController::onSwapArtifacts()
 {
 	return [&]()
-	{
-		GsThread::run([=]
 	{
 		cb->bulkMoveArtifacts(left->id, right->id, true);
-		});
 	};
 }
 
@@ -724,8 +676,6 @@ std::vector<std::pair<SlotID, CStackInstance *>> getStacks(const CArmedInstance
 std::function<void()> CExchangeController::onSwapArmy()
 {
 	return [&]()
-	{
-		GsThread::run([=]
 	{
 		if(left->tempOwner != cb->getMyColor()
 		   || right->tempOwner != cb->getMyColor())
@@ -745,19 +695,24 @@ std::function<void()> CExchangeController::onSwapArmy()
 
 		if(i != leftSlots.end())
 		{
-				for(; i != leftSlots.end(); i++)
+			auto freeSlots = right->getFreeSlots();
+			auto slot = freeSlots.begin();
+
+			for(; i != leftSlots.end() && slot != freeSlots.end(); i++, slot++)
 			{
-					cb->swapCreatures(left, right, i->first, right->getFreeSlot());
+				cb->swapCreatures(left, right, i->first, *slot);
 			}
 		}
 		else if(j != rightSlots.end())
 		{
-				for(; j != rightSlots.end(); j++)
+			auto freeSlots = left->getFreeSlots();
+			auto slot = freeSlots.begin();
+
+			for(; j != rightSlots.end() && slot != freeSlots.end(); j++, slot++)
 			{
-					cb->swapCreatures(left, right, left->getFreeSlot(), j->first);
+				cb->swapCreatures(left, right, *slot, j->first);
 			}
 		}
-		});
 	};
 }
 
@@ -854,10 +809,7 @@ void CExchangeController::moveArtifacts(bool leftToRight)
 		return;
 	}
 
-	GsThread::run([=]
-	{
 	cb->bulkMoveArtifacts(source->id, target->id, false);
-	});
 }
 
 void CExchangeController::moveArtifact(