games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-07-03 00:46:55 +02:00
Code Issues Releases Activity

Fixed crash on opening thieves guild window when player has no heroes.

Browse Source 
Fixed #384, #385, maybe #381
This commit is contained in:
Michał W. Urbańczyk
2010-02-28 12:39:38 +00:00
parent 32b6b9cb17
commit d7ba3571bd
6 changed files with 32 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lib/CGameState.cpp
View File

@ -3163,16 +3163,19 @@ struct statsHLP
static const CGHeroInstance * findBestHero(CGameState * gs, int color)
{
std::vector<CGHeroInstance *> &h = gs->players[color].heroes;
if(!h.size())
return NULL;
//best hero will be that with highest exp
int best = 0;
for(int b=1; b<gs->players[color].heroes.size(); ++b)
for(int b=1; b<h.size(); ++b)
{
if(gs->players[color].heroes[b]->exp > gs->players[color].heroes[best]->exp)
if(h[b]->exp > h[best]->exp)
{
best = b;
}
}
return gs->players[color].heroes[best];
return h[best];
}
//calculates total number of artifacts that belong to given player
@ -3726,6 +3729,8 @@ InfoAboutHero::~InfoAboutHero()
void InfoAboutHero::initFromHero( const CGHeroInstance *h, bool detailed )
{
if(!h) return;
owner = h->tempOwner;
hclass = h->type->heroClass;
name = h->name;