games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-11-25 22:42:04 +02:00
Code Issues Releases Activity

Changes following review:

Browse Source 
- shared_ptr for destructibleEnemyTurns instead of raw pointer
- drop implicit int conversion for BattleHex class
  and implement toInt() instead
- implement necessary operators in BattleHex
- adjust code to work properly with JSON serializer
This commit is contained in:
MichalZr6
2025-01-06 23:05:45 +01:00
parent 4031006317
commit dbe82b94f6
39 changed files with 223 additions and 174 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
test/scripting/LuaSpellEffectTest.cpp
View File

@@ -154,11 +154,11 @@ TEST_F(LuaSpellEffectTest, ApplicableTargetRedirected)
JsonNode first;
first.Vector().emplace_back(static_cast<si16>(hex1));
first.Vector().emplace_back(hex1.toInt());
first.Vector().emplace_back(id1);
JsonNode second;
second.Vector().emplace_back(static_cast<si16>(hex2));
second.Vector().emplace_back(hex2.toInt());
second.Vector().emplace_back(-1);
JsonNode targets;
@@ -193,7 +193,7 @@ TEST_F(LuaSpellEffectTest, ApplyRedirected)
subject->apply(&serverMock, &mechanicsMock, target);
JsonNode first;
first.Vector().emplace_back(static_cast<si16>(hex1));
first.Vector().emplace_back(hex1.toInt());
first.Vector().emplace_back(id1);
JsonNode targets;