games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-08-08 22:26:51 +02:00
Code Issues Releases Activity

Merge pull request #5176 from IvanSavenko/ai_upgrades

Browse Source 
Fix potentially infinite attempts to upgrade units by AI
This commit is contained in:
Ivan Savenko
2024-12-31 16:07:27 +02:00
committed by GitHub
parent 398319a512 f9ce95756f
commit dfa8a956cc
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
AI/Nullkiller/AIGateway.cpp
View File

@ -805,7 +805,11 @@ bool AIGateway::makePossibleUpgrades(const CArmedInstance * obj)
{ {
return id.toCreature()->getAIValue(); return id.toCreature()->getAIValue();
}); });
if(nullkiller->getFreeResources().canAfford(upgradeInfo.getUpgradeCostsFor(upgID) * s->count))
int oldValue = s->getCreature()->getAIValue();
int newValue = upgID.toCreature()->getAIValue();
if(newValue > oldValue && nullkiller->getFreeResources().canAfford(upgradeInfo.getUpgradeCostsFor(upgID) * s->count))
{ {
myCb->upgradeCreature(obj, SlotID(i), upgID); myCb->upgradeCreature(obj, SlotID(i), upgID);
upgraded = true; upgraded = true;