games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-11-23 22:37:55 +02:00
Code Issues Releases Activity

Fixes following review

Browse Source 
Add missing mod to CMap in checkRequiredMods
This commit is contained in:
MichalZr6
2025-05-13 12:51:31 +02:00
parent ef95f34bdb
commit e1b79326de
6 changed files with 40 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
mapeditor/mapcontroller.cpp
View File

@@ -601,20 +601,15 @@ bool MapController::checkRequiredMods(const CGObjectInstance * obj, QString & er
{
if(!_map->mods.count(mod.first))
{
QString submod;
if(!mod.second.parent.empty())
submod = tr(" (submod of %1)").arg(QString::fromStdString(mod.second.parent));
auto reply = QMessageBox::question(main,
tr("Missing Required Mod"),
tr("This object is from the mod '%1'%2.\n\n"
"The mod is currently not in the map's required modifications list.\n\n"
"Do you want to add this mod to the required modifications?\n")
.arg(QString::fromStdString(LIBRARY->modh->getModInfo(mod.first).getVerificationInfo().name), submod),
tr("Missing Required Mod"), modMissingMessage(mod.second) + tr("\n\nDo you want to do that now ?"),
QMessageBox::Yes | QMessageBox::No);
if(reply == QMessageBox::Yes)
{
_map->mods[mod.first] = LIBRARY->modh->getModInfo(mod.first).getVerificationInfo();
Q_EMIT requestModsUpdate(modsInfo, true); // signal for MapSettings
}
else
{
error = tr("This object's mod is mandatory for map to remain valid.");
@@ -625,6 +620,19 @@ bool MapController::checkRequiredMods(const CGObjectInstance * obj, QString & er
return true;
}
QString MapController::modMissingMessage(const ModVerificationInfo & info)
{
QString modName = QString::fromStdString(info.name);
QString submod;
if(!info.parent.empty())
submod = QObject::tr(" (submod of %1)").arg(QString::fromStdString(info.parent));
return QObject::tr("The mod '%1'%2, is required by an object on the map.\n"
"Add it to the map's required mods in Map->General settings.",
"should be consistent with Map->General menu entry translation")
.arg(modName, submod);
}
void MapController::undo()
{
_map->getEditManager()->getUndoManager().undo();