From e82acf4840bdb835bc9eee491d2166e0742ea045 Mon Sep 17 00:00:00 2001 From: Konstantin Date: Wed, 31 May 2023 20:00:30 +0300 Subject: [PATCH] CGHeroInstance: always add obligatory skills Fixes #2198 --- lib/mapObjects/CGHeroInstance.cpp | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/mapObjects/CGHeroInstance.cpp b/lib/mapObjects/CGHeroInstance.cpp index cdc8bed93..55c967fff 100644 --- a/lib/mapObjects/CGHeroInstance.cpp +++ b/lib/mapObjects/CGHeroInstance.cpp @@ -1149,12 +1149,10 @@ std::vector CGHeroInstance::getLevelUpProposedSecondarySkills() auto getObligatorySkills = [](CSkill::Obligatory obl){ std::vector obligatory = {}; - for(int i = 0; i < VLC->skillh->size(); i++) + for(auto i = 0; i < VLC->skillh->size(); i++) if((*VLC->skillh)[SecondarySkill(i)]->obligatory(obl)) - { - obligatory.emplace_back(i); - break; - } + obligatory.emplace_back(i); //Always return all obligatory skills + return obligatory; };