From ea0c553148dece5289fd06476da8558a7aee6395 Mon Sep 17 00:00:00 2001 From: Ivan Savenko Date: Wed, 1 Jan 2025 21:01:23 +0000 Subject: [PATCH] Fix crash on attempt to update mod that depends on unknown mod --- launcher/modManager/cmodlistview_moc.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/launcher/modManager/cmodlistview_moc.cpp b/launcher/modManager/cmodlistview_moc.cpp index 84203c181..22a86694c 100644 --- a/launcher/modManager/cmodlistview_moc.cpp +++ b/launcher/modManager/cmodlistview_moc.cpp @@ -1053,7 +1053,13 @@ QStringList CModListView::getUpdateableMods() for(const auto & modName : modStateModel->getAllMods()) { auto mod = modStateModel->getMod(modName); - if (mod.isUpdateAvailable()) + if (!mod.isUpdateAvailable()) + continue; + + QStringList notInstalledDependencies = getModsToInstall(mod.getID()); + QStringList unavailableDependencies = findUnavailableMods(notInstalledDependencies); + + if (unavailableDependencies.empty()) result.push_back(modName); }