games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-06-15 00:05:02 +02:00
Code Issues Releases Activity

Fix TODO comments

Browse Source
This commit is contained in:
Dydzio
2024-04-01 21:58:17 +02:00
parent e5e14adb51
commit ecb2bcb2db
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/CGameInfoCallback.cpp
View File

@ -294,10 +294,10 @@ bool CGameInfoCallback::isTileGuardedAfterDimensionDoorUse(int3 tile, const CGHe
if(isVisible(tile)) if(isVisible(tile))
canAccessInfo = true; canAccessInfo = true;
else if(VLC->settings()->getBoolean(EGameSettings::DIMENSION_DOOR_TRIGGERS_GUARDS) //TODO: check if available casts > 0 else if(VLC->settings()->getBoolean(EGameSettings::DIMENSION_DOOR_TRIGGERS_GUARDS)
&& isInScreenRange(castingHero->getSightCenter(), tile) && isInScreenRange(castingHero->getSightCenter(), tile)
&& castingHero->canCastThisSpell(static_cast<SpellID>(SpellID::DIMENSION_DOOR).toSpell())) && castingHero->canCastThisSpell(static_cast<SpellID>(SpellID::DIMENSION_DOOR).toSpell()))
canAccessInfo = true; canAccessInfo = true; //TODO: check if available casts > 0, before adding that check make dimension door daily limit popup trigger on spell pick
if(canAccessInfo) if(canAccessInfo)
return !gs->guardingCreatures(tile).empty(); return !gs->guardingCreatures(tile).empty();
@ -540,8 +540,8 @@ const TerrainTile * CGameInfoCallback::getTileForDimensionDoor(int3 tile, const
if(!allowOnlyToUncoveredTiles) if(!allowOnlyToUncoveredTiles)
{ {
if(castingHero->canCastThisSpell(static_cast<SpellID>(SpellID::DIMENSION_DOOR).toSpell()) if(castingHero->canCastThisSpell(static_cast<SpellID>(SpellID::DIMENSION_DOOR).toSpell())
&& isInScreenRange(castingHero->getSightCenter(), tile)) //TODO: check if > 0 casts left && isInScreenRange(castingHero->getSightCenter(), tile))
{ { //TODO: check if available casts > 0, before adding that check make dimension door daily limit popup trigger on spell pick
//we are allowed to get basic blocked/water invisible nearby tile date when casting DD spell //we are allowed to get basic blocked/water invisible nearby tile date when casting DD spell
TerrainTile targetTile = gs->map->getTile(tile); TerrainTile targetTile = gs->map->getTile(tile);
auto obfuscatedTile = std::make_shared<TerrainTile>(); auto obfuscatedTile = std::make_shared<TerrainTile>();