games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-12-01 23:12:49 +02:00
Code Issues Releases Activity

Use BattleHex as const ref wherever possible

Browse Source 
Minor Fixes
Drop unused function from BattleHexArray
This commit is contained in:
MichalZr6
2025-01-13 14:12:00 +01:00
parent 8f63a82d60
commit ecdd394bb1
56 changed files with 335 additions and 355 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/battle/BattleAction.cpp
View File

@@ -43,7 +43,7 @@ BattleAction BattleAction::makeDefend(const battle::Unit * stack)
return ba;
}
BattleAction BattleAction::makeMeleeAttack(const battle::Unit * stack, BattleHex destination, BattleHex attackFrom, bool returnAfterAttack)
BattleAction BattleAction::makeMeleeAttack(const battle::Unit * stack, const BattleHex & destination, const BattleHex & attackFrom, bool returnAfterAttack)
{
BattleAction ba;
ba.side = stack->unitSide(); //FIXME: will it fail if stack mind controlled?
@@ -86,7 +86,7 @@ BattleAction BattleAction::makeCreatureSpellcast(const battle::Unit * stack, con
return ba;
}
BattleAction BattleAction::makeMove(const battle::Unit * stack, BattleHex dest)
BattleAction BattleAction::makeMove(const battle::Unit * stack, const BattleHex & dest)
{
BattleAction ba;
ba.side = stack->unitSide();