From b7ed11f582263052db1eb86b04861b4607fdd58a Mon Sep 17 00:00:00 2001
From: AlexVinS <alexvins@users.noreply.github.com>
Date: Fri, 14 Nov 2014 07:45:44 +0300
Subject: [PATCH 01/19] Fix ERM build (-) there is one regression, but ERM is
 unused yet

---
 scripting/erm/ERM.cbp            |  4 ++--
 scripting/erm/ERMInterpreter.cpp | 20 +++++++++++---------
 scripting/erm/StdInc.h           |  2 --
 3 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/scripting/erm/ERM.cbp b/scripting/erm/ERM.cbp
index 279b417b6..fe93b63e9 100644
--- a/scripting/erm/ERM.cbp
+++ b/scripting/erm/ERM.cbp
@@ -6,7 +6,7 @@
 		<Option pch_mode="2" />
 		<Option compiler="gcc" />
 		<Build>
-			<Target title="Debug">
+			<Target title="Debug-win32-SDL2">
 				<Option output="../ERM" imp_lib="$(TARGET_OUTPUT_DIR)$(TARGET_OUTPUT_BASENAME).a" def_file="$(TARGET_OUTPUT_DIR)$(TARGET_OUTPUT_BASENAME).def" prefix_auto="1" extension_auto="1" />
 				<Option object_output="obj/Debug/" />
 				<Option type="3" />
@@ -16,7 +16,7 @@
 					<Add option="-ggdb" />
 				</Compiler>
 			</Target>
-			<Target title="Release">
+			<Target title="Release-win32-SDL2">
 				<Option output="../ERM" imp_lib="$(TARGET_OUTPUT_DIR)$(TARGET_OUTPUT_BASENAME).a" def_file="$(TARGET_OUTPUT_DIR)$(TARGET_OUTPUT_BASENAME).def" prefix_auto="1" extension_auto="1" />
 				<Option object_output="obj/Release/" />
 				<Option type="3" />
diff --git a/scripting/erm/ERMInterpreter.cpp b/scripting/erm/ERMInterpreter.cpp
index 815aac5b1..d7276e5a2 100644
--- a/scripting/erm/ERMInterpreter.cpp
+++ b/scripting/erm/ERMInterpreter.cpp
@@ -23,9 +23,9 @@
 
 namespace spirit = boost::spirit;
 using namespace VERMInterpreter;
-using namespace boost::assign;
+
 typedef int TUnusedType;
-using namespace boost::assign;
+
 
 ERMInterpreter *erm;
 Environment *topDyn;
@@ -1339,10 +1339,10 @@ struct ERMExpDispatch : boost::static_visitor<>
 					std::vector<int> params(FunctionLocalVars::NUM_PARAMETERS, 0);
 					params.back() = it;
 					//owner->getFuncVars(funNum)->getParam(16) = it;
-					ERMInterpreter::TIDPattern tip;
+					
 					std::vector<int> v1;
-					v1 += funNum;
-					insert(tip) (v1.size(), v1);
+					v1.push_back(funNum);
+					ERMInterpreter::TIDPattern tip = {{v1.size(), v1}};
 					erm->executeTriggerType(TriggerType("FU"), true, tip, params);
 					it = erm->getFuncVars(funNum)->getParam(16);
 				}
@@ -1394,7 +1394,7 @@ struct ERMExpDispatch : boost::static_visitor<>
 					{
 						int heroNum = erm->getIexp(tid[0]).getInt();
 						if(heroNum == -1)
-							hero = icb->getSelectedHero();
+							assert(false); //FIXME: use new hero selection mechanics
 						else
 							hero = icb->getHeroWithSubid(heroNum);
 
@@ -2509,9 +2509,11 @@ struct VNodeEvaluator : boost::static_visitor<VOption>
 	}
 	VOption operator()(VSymbol const& opt) const
 	{
-		std::map<std::string, VFunc::Eopt> symToFunc = boost::assign::map_list_of
-			("<", VFunc::LT)("<=", VFunc::LE)(">", VFunc::GT)(">=", VFunc::GE)("=", VFunc::EQ)("+", VFunc::ADD)("-", VFunc::SUB)
-			("*", VFunc::MULT)("/", VFunc::DIV)("%", VFunc::MOD);
+		std::map<std::string, VFunc::Eopt> symToFunc =
+		{
+			{"<", VFunc::LT},{"<=", VFunc::LE},{">", VFunc::GT},{">=", VFunc::GE},{"=", VFunc::EQ},{"+", VFunc::ADD},{"-", VFunc::SUB},
+			{"*", VFunc::MULT},{"/", VFunc::DIV},{"%", VFunc::MOD}
+		};
 
 		//check keywords
 		if(opt.text == "quote")
diff --git a/scripting/erm/StdInc.h b/scripting/erm/StdInc.h
index 3dc7e6243..76f778c6e 100644
--- a/scripting/erm/StdInc.h
+++ b/scripting/erm/StdInc.h
@@ -5,6 +5,4 @@
 // This header should be treated as a pre compiled header file(PCH) in the compiler building settings.
 
 // Here you can add specific libraries and macros which are specific to this project.
-#include <boost/variant.hpp>
-#include <boost/optional.hpp>
 

From 4c5c83aa1fe86fac55949ee7b825f296c301d069 Mon Sep 17 00:00:00 2001
From: AlexVinS <alexvins@users.noreply.github.com>
Date: Fri, 14 Nov 2014 07:48:56 +0300
Subject: [PATCH 02/19] Re add ERM to workspace * To keep track of successful
 build

---
 vcmi.workspace | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/vcmi.workspace b/vcmi.workspace
index 14ea3c95a..1bf32ef39 100644
--- a/vcmi.workspace
+++ b/vcmi.workspace
@@ -6,8 +6,8 @@
 			<Depends filename="lib/minizip/minizip.cbp" />
 		</Project>
 		<Project filename="client/VCMI_client.cbp">
-			<Depends filename="lib/VCMI_lib.cbp" />
 			<Depends filename="server/VCMI_server.cbp" />
+			<Depends filename="lib/VCMI_lib.cbp" />
 		</Project>
 		<Project filename="server/VCMI_server.cbp">
 			<Depends filename="lib/VCMI_lib.cbp" />
@@ -17,8 +17,8 @@
 			<Depends filename="lib/VCMI_lib.cbp" />
 		</Project>
 		<Project filename="AI/VCAI/VCAI.cbp">
-			<Depends filename="lib/VCMI_lib.cbp" />
 			<Depends filename="AI/FuzzyLite/FuzzyLite.cbp" />
+			<Depends filename="lib/VCMI_lib.cbp" />
 		</Project>
 		<Project filename="AI/StupidAI/StupidAI.cbp">
 			<Depends filename="lib/VCMI_lib.cbp" />
@@ -27,13 +27,16 @@
 			<Depends filename="lib/VCMI_lib.cbp" />
 		</Project>
 		<Project filename="test/Test.cbp">
-			<Depends filename="lib/VCMI_lib.cbp" />
 			<Depends filename="client/VCMI_client.cbp" />
 			<Depends filename="server/VCMI_server.cbp" />
 			<Depends filename="AI/EmptyAI/EmptyAI.cbp" />
 			<Depends filename="AI/VCAI/VCAI.cbp" />
 			<Depends filename="AI/StupidAI/StupidAI.cbp" />
 			<Depends filename="AI/BattleAI/BattleAI.cbp" />
+			<Depends filename="lib/VCMI_lib.cbp" />
+		</Project>
+		<Project filename="scripting/erm/ERM.cbp">
+			<Depends filename="lib/VCMI_lib.cbp" />
 		</Project>
 	</Workspace>
 </CodeBlocks_workspace_file>

From 68d1105233bead1297ba4602c1d8b90a0de8e21c Mon Sep 17 00:00:00 2001
From: AlexVinS <alexvins@users.noreply.github.com>
Date: Sat, 15 Nov 2014 20:22:50 +0300
Subject: [PATCH 03/19] Fix creature window not showing bonus description

---
 client/windows/CCreatureWindow.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/client/windows/CCreatureWindow.cpp b/client/windows/CCreatureWindow.cpp
index d85af50df..ed7f6becc 100644
--- a/client/windows/CCreatureWindow.cpp
+++ b/client/windows/CCreatureWindow.cpp
@@ -749,6 +749,7 @@ void CStackWindow::initBonusesList()
 	for(Bonus* b : output)
 	{
 		bonusInfo.name = info->stackNode->bonusToString(b, false);
+		bonusInfo.description = info->stackNode->bonusToString(b, true);
 		bonusInfo.imagePath = info->stackNode->bonusToGraphics(b);
 
 		//if it's possible to give any description or image for this kind of bonus

From c43b218d6412a39a2b428a8d2e389357dd83ea32 Mon Sep 17 00:00:00 2001
From: AlexVinS <alexvins@users.noreply.github.com>
Date: Sat, 15 Nov 2014 20:39:21 +0300
Subject: [PATCH 04/19] Fix duplicate MR bonus display

---
 client/windows/CCreatureWindow.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/windows/CCreatureWindow.cpp b/client/windows/CCreatureWindow.cpp
index ed7f6becc..d66b6be69 100644
--- a/client/windows/CCreatureWindow.cpp
+++ b/client/windows/CCreatureWindow.cpp
@@ -754,7 +754,7 @@ void CStackWindow::initBonusesList()
 
 		//if it's possible to give any description or image for this kind of bonus
 		//TODO: figure out why half of bonuses don't have proper description
-		if (!bonusInfo.name.empty() || !bonusInfo.imagePath.empty())
+		if ((!bonusInfo.name.empty() || !bonusInfo.imagePath.empty())&& b->type != Bonus::MAGIC_RESISTANCE)
 			activeBonuses.push_back(bonusInfo);
 	}
 

From 885b495cf4d4ec8fafba68b4167a41371fbb62b3 Mon Sep 17 00:00:00 2001
From: AlexVinS <alexvins@users.noreply.github.com>
Date: Sat, 15 Nov 2014 21:54:45 +0300
Subject: [PATCH 05/19] [Creature window] Fix creature art dismount possibility

---
 client/windows/CCreatureWindow.cpp | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/client/windows/CCreatureWindow.cpp b/client/windows/CCreatureWindow.cpp
index d66b6be69..e6992bc88 100644
--- a/client/windows/CCreatureWindow.cpp
+++ b/client/windows/CCreatureWindow.cpp
@@ -824,6 +824,7 @@ CStackWindow::CStackWindow(const CStackInstance * stack, bool popup):
 	info->creature = stack->type;
 	info->creatureCount = stack->count;
 	info->popupWindow = popup;
+	info->owner = dynamic_cast<const CGHeroInstance *> (stack->armyObj);	
 	init();
 }
 
@@ -840,6 +841,7 @@ CStackWindow::CStackWindow(const CStackInstance * stack, std::function<void()> d
 	info->upgradeInfo->info = upgradeInfo;
 	info->upgradeInfo->callback = callback;
 	info->dismissInfo->callback = dismiss;
+	info->owner = dynamic_cast<const CGHeroInstance *> (stack->armyObj);
 	init();
 }
 
@@ -852,6 +854,7 @@ CStackWindow::CStackWindow(const CCommanderInstance * commander, bool popup):
 	info->commander = commander;
 	info->creatureCount = 1;
 	info->popupWindow = popup;
+	info->owner = dynamic_cast<const CGHeroInstance *> (commander->armyObj);	
 	init();
 }
 
@@ -866,6 +869,7 @@ CStackWindow::CStackWindow(const CCommanderInstance * commander, std::vector<ui3
 	info->levelupInfo = StackWindowInfo::CommanderLevelInfo();
 	info->levelupInfo->skills = skills;
 	info->levelupInfo->callback = callback;
+	info->owner = dynamic_cast<const CGHeroInstance *> (commander->armyObj);		
 	init();
 }
 

From e73c60740c17232887dbaa455c2d86e50cd88906 Mon Sep 17 00:00:00 2001
From: KroArtem <artem.krosheninnikov@gmail.com>
Date: Sun, 16 Nov 2014 20:48:29 +0300
Subject: [PATCH 06/19] corrected text in vcmibuilder, corrected errors and
 warnings from cppcheck

---
 client/CPlayerInterface.cpp               |  2 +-
 client/battle/CBattleInterface.cpp        | 10 +++++-----
 client/battle/CBattleInterfaceClasses.cpp |  2 +-
 client/widgets/MiscWidgets.cpp            |  2 +-
 lib/CBattleCallback.cpp                   |  5 ++---
 lib/Connection.cpp                        |  2 +-
 lib/mapObjects/CRewardableObject.cpp      |  2 +-
 lib/rmg/CRmgTemplateZone.cpp              | 10 +++++++---
 server/CGameHandler.cpp                   |  2 +-
 vcmibuilder                               |  2 +-
 10 files changed, 21 insertions(+), 18 deletions(-)

diff --git a/client/CPlayerInterface.cpp b/client/CPlayerInterface.cpp
index 6671d93e6..380e04ef4 100644
--- a/client/CPlayerInterface.cpp
+++ b/client/CPlayerInterface.cpp
@@ -678,7 +678,7 @@ void CPlayerInterface::battleStacksHealedRes(const std::vector<std::pair<ui32, u
 
 			//print info about life drain
 			char textBuf[1000];
-			sprintf(textBuf, CGI->generaltexth->allTexts[361 + textOff].c_str(), attacker->getCreature()->nameSing.c_str(),
+			snprintf(textBuf, 1000, CGI->generaltexth->allTexts[361 + textOff].c_str(), attacker->getCreature()->nameSing.c_str(),
 				healedStacks[0].second, defender->getCreature()->namePl.c_str());
 			battleInt->console->addText(textBuf);
 		}
diff --git a/client/battle/CBattleInterface.cpp b/client/battle/CBattleInterface.cpp
index 6a75eefbb..0a2cb05ed 100644
--- a/client/battle/CBattleInterface.cpp
+++ b/client/battle/CBattleInterface.cpp
@@ -832,7 +832,7 @@ void CBattleInterface::bFleef()
 				heroName = defendingHeroInstance->name;
 		//calculating text
 		char buffer[1000];
-		sprintf(buffer, CGI->generaltexth->allTexts[340].c_str(), heroName.c_str()); //The Shackles of War are present.  %s can not retreat!
+		snprintf(buffer, 1000, CGI->generaltexth->allTexts[340].c_str(), heroName.c_str()); //The Shackles of War are present.  %s can not retreat!
 
 		//printing message
 		curInt->showInfoDialog(std::string(buffer), comps);
@@ -1523,7 +1523,7 @@ void CBattleInterface::battleStacksEffectsSet(const SetStackEffect & sse)
 			BonusList defenseBonuses = *(stack->getBonuses(Selector::typeSubtype(Bonus::PRIMARY_SKILL, PrimarySkill::DEFENSE)));
 			defenseBonuses.remove_if(Selector::durationType(Bonus::STACK_GETS_TURN)); //remove bonuses gained from defensive stance
 			int val = stack->Defense() - defenseBonuses.totalValue();
-			sprintf(txt, CGI->generaltexth->allTexts[txtid].c_str(),  (stack->count != 1) ? stack->getCreature()->namePl.c_str() : stack->getCreature()->nameSing.c_str(), val);
+			sprintf(txt, 4000, CGI->generaltexth->allTexts[txtid].c_str(),  (stack->count != 1) ? stack->getCreature()->namePl.c_str() : stack->getCreature()->nameSing.c_str(), val);
 			console->addText(txt);
 		}
 	}
@@ -1797,19 +1797,19 @@ void CBattleInterface::printConsoleAttacked( const CStack * defender, int dmg, i
 	int end = 0;
 	if (attacker) //ignore if stacks were killed by spell
 	{
-		end = sprintf(tabh, CGI->generaltexth->allTexts[attacker->count > 1 ? 377 : 376].c_str(),
+		end = snprintf(tabh, 200, CGI->generaltexth->allTexts[attacker->count > 1 ? 377 : 376].c_str(),
 		(attacker->count > 1 ? attacker->getCreature()->namePl.c_str() : attacker->getCreature()->nameSing.c_str()), dmg);
 	}
 	if(killed > 0)
 	{
 		if(killed > 1)
 		{
-			sprintf(tabh + end, CGI->generaltexth->allTexts[379].c_str(), killed,
+			snprintf(tabh + end, 400, CGI->generaltexth->allTexts[379].c_str(), killed,
 				multiple ? CGI->generaltexth->allTexts[43].c_str() : defender->getCreature()->namePl.c_str()); // creatures perish
 		}
 		else //killed == 1
 		{
-			sprintf(tabh + end, CGI->generaltexth->allTexts[378].c_str(),
+			snprintf(tabh + end, 400, CGI->generaltexth->allTexts[378].c_str(),
 				multiple ? CGI->generaltexth->allTexts[42].c_str() : defender->getCreature()->nameSing.c_str()); // creature perishes
 		}
 	}
diff --git a/client/battle/CBattleInterfaceClasses.cpp b/client/battle/CBattleInterfaceClasses.cpp
index b14a38651..1f64bee80 100644
--- a/client/battle/CBattleInterfaceClasses.cpp
+++ b/client/battle/CBattleInterfaceClasses.cpp
@@ -579,7 +579,7 @@ void CClickableHex::mouseMoved(const SDL_MouseMotionEvent &sEvent)
 		{
 			char tabh[160];
 			const std::string & attackedName = attackedStack->count == 1 ? attackedStack->getCreature()->nameSing : attackedStack->getCreature()->namePl;
-			sprintf(tabh, CGI->generaltexth->allTexts[220].c_str(), attackedName.c_str());
+			snprintf(tabh, 160, CGI->generaltexth->allTexts[220].c_str(), attackedName.c_str());
 			myInterface->console->alterTxt = std::string(tabh);
 			setAlterText = true;
 		}
diff --git a/client/widgets/MiscWidgets.cpp b/client/widgets/MiscWidgets.cpp
index 01c2fef54..01c9a927b 100644
--- a/client/widgets/MiscWidgets.cpp
+++ b/client/widgets/MiscWidgets.cpp
@@ -383,7 +383,7 @@ void MoraleLuckBox::set(const IBonusBearer *node)
 	else
 	{
 		//it's a creature window
-		if ((morale && node->hasBonusOfType(Bonus::UNDEAD)) ||
+		if ((morale && node && node->hasBonusOfType(Bonus::UNDEAD)) ||
 			node->hasBonusOfType(Bonus::BLOCK_MORALE) || node->hasBonusOfType(Bonus::NON_LIVING))
 		{
 			text += CGI->generaltexth->arraytxt[113]; //unaffected by morale
diff --git a/lib/CBattleCallback.cpp b/lib/CBattleCallback.cpp
index 4ccd287aa..775e0ad36 100644
--- a/lib/CBattleCallback.cpp
+++ b/lib/CBattleCallback.cpp
@@ -1378,11 +1378,11 @@ AttackableTiles CBattleInfoCallback::getPotentiallyAttackableHexes (const CStack
 		case -WN: //-17 //left-up or right-up
 		case WN + 1: //18 //right-down
 		case -WN + 1: //-16 //right-up
-			BattleHex::checkAndPush (destinationTile.hex + pseudoVector + ((hex/WN)%2 ? 1 : -1 ), hexes);
+			BattleHex::checkAndPush (destinationTile.hex + pseudoVector + (((hex/WN)%2) ? 1 : -1 ), hexes);
 			break;
 		case WN-1: //16 //left-down
 		case -WN-1: //-18 //left-up
-			BattleHex::checkAndPush (destinationTile.hex + pseudoVector + ((hex/WN)%2 ? 1 : 0), hexes);
+			BattleHex::checkAndPush (destinationTile.hex + pseudoVector + (((hex/WN)%2) ? 1 : 0), hexes);
 			break;
 		}
 		for (BattleHex tile : hexes)
@@ -1819,7 +1819,6 @@ ESpellCastProblem::ESpellCastProblem CBattleInfoCallback::battleCanCastThisSpell
 					case CSpell::NEUTRAL:
 							targetExists = true;
 							break;
-						break;
 					case CSpell::NEGATIVE:
 						if(!casterStack || !ti.smart)
 						{
diff --git a/lib/Connection.cpp b/lib/Connection.cpp
index 103108f0d..3452ddc18 100644
--- a/lib/Connection.cpp
+++ b/lib/Connection.cpp
@@ -478,7 +478,7 @@ std::vector<CTypeList::TypeInfoPtr> CTypeList::castSequence(TypeInfoPtr from, Ty
 		std::map<TypeInfoPtr, TypeInfoPtr> previous;
 		std::queue<TypeInfoPtr> q;
 		q.push(to);
-		while(q.size())
+		while(!q.empty())
 		{
 			auto typeNode = q.front();
 			q.pop();
diff --git a/lib/mapObjects/CRewardableObject.cpp b/lib/mapObjects/CRewardableObject.cpp
index eca4fa46a..4ca573462 100644
--- a/lib/mapObjects/CRewardableObject.cpp
+++ b/lib/mapObjects/CRewardableObject.cpp
@@ -677,7 +677,7 @@ void CGBonusingObject::initObj()
 		for (int i=0; i<6; i++)
 		{
 			info[i].limiter.dayOfWeek = i+1;
-			configureBonus(info[i], i%2 ? Bonus::MORALE : Bonus::LUCK, 1, 68);
+			configureBonus(info[i], (i%2) ? Bonus::MORALE : Bonus::LUCK, 1, 68);
 			info[i].message.addTxt(MetaString::ADVOB_TXT, 62);
 			soundID = soundBase::experience;
 		}
diff --git a/lib/rmg/CRmgTemplateZone.cpp b/lib/rmg/CRmgTemplateZone.cpp
index a5dc76b19..cd8af623a 100644
--- a/lib/rmg/CRmgTemplateZone.cpp
+++ b/lib/rmg/CRmgTemplateZone.cpp
@@ -430,7 +430,7 @@ void CRmgTemplateZone::fractalize(CMapGenerator* gen)
 	}
 	assert (clearedTiles.size()); //this should come from zone connections
 
-	while (possibleTiles.size())
+	while (!possibleTiles.empty())
 	{
 		//link tiles in random order
 		std::vector<int3> tilesToMakePath(possibleTiles.begin(), possibleTiles.end());
@@ -811,7 +811,7 @@ bool CRmgTemplateZone::createTreasurePile (CMapGenerator* gen, int3 &pos, float
 			}
 	}
 
-	if (treasures.size())
+	if (!treasures.empty())
 	{
 		//find object closest to zone center, then connect it to the middle of the zone
 		int3 closestFreeTile (-1,-1,-1);
@@ -2000,7 +2000,7 @@ void CRmgTemplateZone::addAllPossibleObjects (CMapGenerator* gen)
 			{
 				creaturesAmount = boost::math::round(creaturesAmount / 5) * 5;
 			}
-			else if (creaturesAmount <= 12)
+			else if (creaturesAmount <= 120)
 			{
 				creaturesAmount = boost::math::round(creaturesAmount / 10) * 10;
 			}
@@ -2070,12 +2070,16 @@ void CRmgTemplateZone::addAllPossibleObjects (CMapGenerator* gen)
 					{
 						case 1:
 							school = spell->air;
+							break;
 						case 2:
 							school = spell->earth;
+							break;
 						case 3:
 							school = spell->fire;
+							break;
 						case 4:
 							school = spell->water;
+							break;
 					}
 					if (school)
 						spells.push_back(spell);
diff --git a/server/CGameHandler.cpp b/server/CGameHandler.cpp
index a3136a72f..c6779b6b2 100644
--- a/server/CGameHandler.cpp
+++ b/server/CGameHandler.cpp
@@ -3389,7 +3389,7 @@ bool CGameHandler::makeBattleAction( BattleAction &ba )
 				break;
 			}
 
-			if(destinationStack && stack->ID == destinationStack->ID) //we should just move, it will be handled by following check
+			if(destinationStack && stack && stack->ID == destinationStack->ID) //we should just move, it will be handled by following check
 			{
 				destinationStack = nullptr;
 			}
diff --git a/vcmibuilder b/vcmibuilder
index 1d64abfb2..2b1dc6006 100755
--- a/vcmibuilder
+++ b/vcmibuilder
@@ -56,7 +56,7 @@ then
 #	echo " --download       " "Automatically download optional package using wget"
 #	echo "                  " "Requires wget and Internet connection"
 #	echo
-	echo " --dest DIRECTORY " "Path where resulting data will be placed. Default is ~/.vcmi"
+	echo " --dest DIRECTORY " "Path where resulting data will be placed. Default is ~/.local/share/vcmi"
 	echo
 	echo " --validate       " "Run basic validness checks"
 	exit 0

From 4dd1ca5e78622313cc4e35ec7104b4e657a46450 Mon Sep 17 00:00:00 2001
From: ArseniyShestakov <mr.ash.x+github@gmail.com>
Date: Mon, 17 Nov 2014 03:26:18 +0300
Subject: [PATCH 07/19] Fix bonuses of Rampart's Treasury and Fountain of
 Fortune

Change IDs of two special buildings in Rampart to make them identical with one in config files / game assets.

Original code was introduced in 0ca9f64 with those two IDs likely was typo. As result Fountain of Fortune +2 luck bonus was given to Treasury and Treasury's weekly bonus didn't worked at all.
---
 lib/GameConstants.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/GameConstants.h b/lib/GameConstants.h
index db28084cc..4447c1d6f 100644
--- a/lib/GameConstants.h
+++ b/lib/GameConstants.h
@@ -333,8 +333,8 @@ public:
 		BROTHERHOOD = SPECIAL_3,
 
 		MYSTIC_POND         = SPECIAL_1,
-		FOUNTAIN_OF_FORTUNE = SPECIAL_3, //Rampart
-		TREASURY            = SPECIAL_4,
+		FOUNTAIN_OF_FORTUNE = SPECIAL_2, //Rampart
+		TREASURY            = SPECIAL_3,
 
 		ARTIFACT_MERCHANT = SPECIAL_1,
 		LOOKOUT_TOWER     = SPECIAL_2, //Tower

From 2812334de9da16ec52bcacaccacffcb4c98594cf Mon Sep 17 00:00:00 2001
From: josch <j.schauer@email.de>
Date: Mon, 17 Nov 2014 11:42:22 +0100
Subject: [PATCH 08/19] add FL_CPP11 preprocessor define independent of which
 fuzzylite is used

---
 AI/CMakeLists.txt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/AI/CMakeLists.txt b/AI/CMakeLists.txt
index 1d6acb433..82856a671 100644
--- a/AI/CMakeLists.txt
+++ b/AI/CMakeLists.txt
@@ -3,13 +3,14 @@ cmake_minimum_required(VERSION 2.8)
 
 find_package(Fuzzylite)
 
+if(NOT MSVC)
+    add_definitions(-DFL_CPP11)
+    set(FL_CPP11 ON CACHE BOOL "")
+endif()
+
 if (NOT FL_FOUND)
     set(FL_BUILD_BINARY OFF CACHE BOOL "")
     set(FL_BUILD_SHARED OFF CACHE BOOL "")
-    if(NOT MSVC)
-        add_definitions(-DFL_CPP11)
-        set(FL_CPP11 ON CACHE BOOL "")
-    endif()
     add_subdirectory(FuzzyLite/fuzzylite)
 endif()
 add_subdirectory(BattleAI)

From c36042f8c736ccd6c06ea72f1af13279af26e8c4 Mon Sep 17 00:00:00 2001
From: josch <j.schauer@email.de>
Date: Mon, 17 Nov 2014 12:19:29 +0100
Subject: [PATCH 09/19] rename preprocessor variable VCMI_LINUX to VCMI_XDG

 - the variable is only used to enable XDG support
 - XDG is not exclusive to linux
---
 Global.h         |  2 +-
 lib/VCMIDirs.cpp | 26 +++++++++++++-------------
 2 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/Global.h b/Global.h
index a7f4a6146..d047ee532 100644
--- a/Global.h
+++ b/Global.h
@@ -53,7 +53,7 @@ static_assert(sizeof(bool) == 1, "Bool needs to be 1 byte in size.");
 #  error "Windows CE isn't supported"
 #elif defined(__linux__) || defined(__gnu_linux__) || defined(linux) || defined(__linux)
 #  define VCMI_UNIX
-#  define VCMI_LINUX
+#  define VCMI_XDG
 #  ifdef __ANDROID__
 #    define VCMI_ANDROID 
 #  endif
diff --git a/lib/VCMIDirs.cpp b/lib/VCMIDirs.cpp
index be83e9a6a..679b68fd0 100644
--- a/lib/VCMIDirs.cpp
+++ b/lib/VCMIDirs.cpp
@@ -449,8 +449,8 @@ bfs::path VCMIDirsOSX::libraryPath() const { return "."; }
 bfs::path VCMIDirsOSX::binaryPath() const { return "."; }
 
 std::string VCMIDirsOSX::libraryName(const std::string& basename) const { return "lib" + basename + ".dylib"; }
-#elif defined(VCMI_LINUX)
-class VCMIDirsLinux : public IVCMIDirsUNIX
+#elif defined(VCMI_XDG)
+class VCMIDirsXDG : public IVCMIDirsUNIX
 {
 public:
 	boost::filesystem::path userDataPath() const override;
@@ -465,7 +465,7 @@ public:
 	std::string libraryName(const std::string& basename) const override;
 };
 
-bfs::path VCMIDirsLinux::userDataPath() const
+bfs::path VCMIDirsXDG::userDataPath() const
 {
 	// $XDG_DATA_HOME, default: $HOME/.local/share
 	const char* homeDir;
@@ -476,7 +476,7 @@ bfs::path VCMIDirsLinux::userDataPath() const
 	else
 		return ".";
 }
-bfs::path VCMIDirsLinux::userCachePath() const
+bfs::path VCMIDirsXDG::userCachePath() const
 {
 	// $XDG_CACHE_HOME, default: $HOME/.cache
 	const char* tempResult;
@@ -487,7 +487,7 @@ bfs::path VCMIDirsLinux::userCachePath() const
 	else
 		return ".";
 }
-bfs::path VCMIDirsLinux::userConfigPath() const
+bfs::path VCMIDirsXDG::userConfigPath() const
 {
 	// $XDG_CONFIG_HOME, default: $HOME/.config
 	const char* tempResult;
@@ -499,7 +499,7 @@ bfs::path VCMIDirsLinux::userConfigPath() const
 		return ".";
 }
 
-std::vector<bfs::path> VCMIDirsLinux::dataPaths() const
+std::vector<bfs::path> VCMIDirsXDG::dataPaths() const
 {
 	// $XDG_DATA_DIRS, default: /usr/local/share/:/usr/share/
 
@@ -528,12 +528,12 @@ std::vector<bfs::path> VCMIDirsLinux::dataPaths() const
 	return ret;
 }
 
-bfs::path VCMIDirsLinux::libraryPath() const { return M_LIB_DIR; }
-bfs::path VCMIDirsLinux::binaryPath() const { return M_BIN_DIR; }
+bfs::path VCMIDirsXDG::libraryPath() const { return M_LIB_DIR; }
+bfs::path VCMIDirsXDG::binaryPath() const { return M_BIN_DIR; }
 
-std::string VCMIDirsLinux::libraryName(const std::string& basename) const { return "lib" + basename + ".so"; }
+std::string VCMIDirsXDG::libraryName(const std::string& basename) const { return "lib" + basename + ".so"; }
 #ifdef VCMI_ANDROID
-class VCMIDirsAndroid : public VCMIDirsLinux
+class VCMIDirsAndroid : public VCMIDirsXDG
 {
 public:
 	boost::filesystem::path userDataPath() const override;
@@ -553,7 +553,7 @@ std::vector<bfs::path> VCMIDirsAndroid::dataPaths() const
 	return std::vector<bfs::path>(1, userDataPath());
 }
 #endif // VCMI_ANDROID
-#endif // VCMI_APPLE, VCMI_LINUX
+#endif // VCMI_APPLE, VCMI_XDG
 #endif // VCMI_WINDOWS, VCMI_UNIX
 
 // Getters for interfaces are separated for clarity.
@@ -565,8 +565,8 @@ namespace VCMIDirs
 			static VCMIDirsWIN32 singleton;
 		#elif defined(VCMI_ANDROID)
 			static VCMIDirsAndroid singleton;
-		#elif defined(VCMI_LINUX)
-			static VCMIDirsLinux singleton;
+		#elif defined(VCMI_XDG)
+			static VCMIDirsXDG singleton;
 		#elif defined(VCMI_APPLE)
 			static VCMIDirsOSX singleton;
 		#endif

From a96b5e79054e7e1fb9469bea577b914766284296 Mon Sep 17 00:00:00 2001
From: josch <j.schauer@email.de>
Date: Mon, 17 Nov 2014 12:25:10 +0100
Subject: [PATCH 10/19] add support for FreeBSD

---
 Global.h              | 4 ++++
 lib/CThreadHelper.cpp | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/Global.h b/Global.h
index d047ee532..f8b83cf38 100644
--- a/Global.h
+++ b/Global.h
@@ -57,6 +57,10 @@ static_assert(sizeof(bool) == 1, "Bool needs to be 1 byte in size.");
 #  ifdef __ANDROID__
 #    define VCMI_ANDROID 
 #  endif
+#elif defined(__FreeBSD_kernel__) || defined(__FreeBSD__)
+#  define VCMI_UNIX
+#  define VCMI_XDG
+#  define VCMI_FREEBSD
 #elif defined(__APPLE__) && defined(__MACH__)
 #  define VCMI_UNIX
 #  define VCMI_APPLE
diff --git a/lib/CThreadHelper.cpp b/lib/CThreadHelper.cpp
index cbbeeb292..42d64d057 100644
--- a/lib/CThreadHelper.cpp
+++ b/lib/CThreadHelper.cpp
@@ -3,7 +3,7 @@
 
 #ifdef VCMI_WINDOWS
 	#include <windows.h>
-#elif !defined(VCMI_APPLE)
+#elif !defined(VCMI_APPLE) && !defined(VCMI_FREEBSD)
 	#include <sys/prctl.h>
 #endif
 /*

From 5c356f4415f92ea8dc873aa3911dd8f23b617c22 Mon Sep 17 00:00:00 2001
From: josch <j.schauer@email.de>
Date: Mon, 17 Nov 2014 13:15:50 +0100
Subject: [PATCH 11/19] add support for the HURD

---
 Global.h              | 4 ++++
 lib/CThreadHelper.cpp | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/Global.h b/Global.h
index f8b83cf38..c5d10960e 100644
--- a/Global.h
+++ b/Global.h
@@ -61,6 +61,10 @@ static_assert(sizeof(bool) == 1, "Bool needs to be 1 byte in size.");
 #  define VCMI_UNIX
 #  define VCMI_XDG
 #  define VCMI_FREEBSD
+#elif defined(__GNU__) || defined(__gnu_hurd__) || (defined(__MACH__) && !defined(__APPLE))
+#  define VCMI_UNIX
+#  define VCMI_XDG
+#  define VCMI_HURD
 #elif defined(__APPLE__) && defined(__MACH__)
 #  define VCMI_UNIX
 #  define VCMI_APPLE
diff --git a/lib/CThreadHelper.cpp b/lib/CThreadHelper.cpp
index 42d64d057..20273906b 100644
--- a/lib/CThreadHelper.cpp
+++ b/lib/CThreadHelper.cpp
@@ -3,7 +3,7 @@
 
 #ifdef VCMI_WINDOWS
 	#include <windows.h>
-#elif !defined(VCMI_APPLE) && !defined(VCMI_FREEBSD)
+#elif !defined(VCMI_APPLE) && !defined(VCMI_FREEBSD) && !defined(VCMI_HURD)
 	#include <sys/prctl.h>
 #endif
 /*

From 82b278307ff65a7bf408facb5afb49cdf827d87b Mon Sep 17 00:00:00 2001
From: KroArtem <artem.krosheninnikov@gmail.com>
Date: Mon, 17 Nov 2014 23:08:08 +0300
Subject: [PATCH 12/19] fixed typo

---
 client/battle/CBattleInterface.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/battle/CBattleInterface.cpp b/client/battle/CBattleInterface.cpp
index 0a2cb05ed..22502531e 100644
--- a/client/battle/CBattleInterface.cpp
+++ b/client/battle/CBattleInterface.cpp
@@ -1523,7 +1523,7 @@ void CBattleInterface::battleStacksEffectsSet(const SetStackEffect & sse)
 			BonusList defenseBonuses = *(stack->getBonuses(Selector::typeSubtype(Bonus::PRIMARY_SKILL, PrimarySkill::DEFENSE)));
 			defenseBonuses.remove_if(Selector::durationType(Bonus::STACK_GETS_TURN)); //remove bonuses gained from defensive stance
 			int val = stack->Defense() - defenseBonuses.totalValue();
-			sprintf(txt, 4000, CGI->generaltexth->allTexts[txtid].c_str(),  (stack->count != 1) ? stack->getCreature()->namePl.c_str() : stack->getCreature()->nameSing.c_str(), val);
+			snprintf(txt, 4000, CGI->generaltexth->allTexts[txtid].c_str(),  (stack->count != 1) ? stack->getCreature()->namePl.c_str() : stack->getCreature()->nameSing.c_str(), val);
 			console->addText(txt);
 		}
 	}

From a93951895082bca703c61d39748d43981ab3c220 Mon Sep 17 00:00:00 2001
From: Adrian Lang <mail@adrianlang.de>
Date: Tue, 18 Nov 2014 09:55:27 +0100
Subject: [PATCH 13/19] vcmibuilder: Support another root directory

On my disk (HoMM 3 Complete Version 4.0 September 2000), LangInde_Program_Files is the root directory.
---
 vcmibuilder | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/vcmibuilder b/vcmibuilder
index 1d64abfb2..596bd39d3 100755
--- a/vcmibuilder
+++ b/vcmibuilder
@@ -181,6 +181,9 @@ then
 	elif [ -d "$data_dir""/Program_Files" ] 
 	then
 		mv "$data_dir"/Program_Files/* "$data_dir" 
+	elif [ -d "$data_dir""/LangInde_Program_Files" ]
+	then
+		mv "$data_dir"/LangInde_Program_Files/* "$data_dir"
 	else
 		echo "Error: failed to find extracted game files!"
 		echo "Extracted directories are: "

From 305ce5b53db12645ee584d190888b8477717a2c1 Mon Sep 17 00:00:00 2001
From: KroArtem <artem.krosheninnikov@gmail.com>
Date: Thu, 20 Nov 2014 15:14:16 +0300
Subject: [PATCH 14/19] fixed else statement

---
 lib/rmg/CRmgTemplateZone.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/rmg/CRmgTemplateZone.cpp b/lib/rmg/CRmgTemplateZone.cpp
index cd8af623a..3b3218e1a 100644
--- a/lib/rmg/CRmgTemplateZone.cpp
+++ b/lib/rmg/CRmgTemplateZone.cpp
@@ -2000,7 +2000,7 @@ void CRmgTemplateZone::addAllPossibleObjects (CMapGenerator* gen)
 			{
 				creaturesAmount = boost::math::round(creaturesAmount / 5) * 5;
 			}
-			else if (creaturesAmount <= 120)
+			else
 			{
 				creaturesAmount = boost::math::round(creaturesAmount / 10) * 10;
 			}

From 6da79d01d7f3c6ddf268173e10b07f4f4ee6378e Mon Sep 17 00:00:00 2001
From: KroArtem <artem.krosheninnikov@gmail.com>
Date: Thu, 20 Nov 2014 15:33:22 +0300
Subject: [PATCH 15/19] reverted changes back

---
 lib/Connection.cpp           | 2 +-
 lib/rmg/CRmgTemplateZone.cpp | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/Connection.cpp b/lib/Connection.cpp
index 3452ddc18..103108f0d 100644
--- a/lib/Connection.cpp
+++ b/lib/Connection.cpp
@@ -478,7 +478,7 @@ std::vector<CTypeList::TypeInfoPtr> CTypeList::castSequence(TypeInfoPtr from, Ty
 		std::map<TypeInfoPtr, TypeInfoPtr> previous;
 		std::queue<TypeInfoPtr> q;
 		q.push(to);
-		while(!q.empty())
+		while(q.size())
 		{
 			auto typeNode = q.front();
 			q.pop();
diff --git a/lib/rmg/CRmgTemplateZone.cpp b/lib/rmg/CRmgTemplateZone.cpp
index 3b3218e1a..7b838dec9 100644
--- a/lib/rmg/CRmgTemplateZone.cpp
+++ b/lib/rmg/CRmgTemplateZone.cpp
@@ -430,7 +430,7 @@ void CRmgTemplateZone::fractalize(CMapGenerator* gen)
 	}
 	assert (clearedTiles.size()); //this should come from zone connections
 
-	while (!possibleTiles.empty())
+	while (possibleTiles.size())
 	{
 		//link tiles in random order
 		std::vector<int3> tilesToMakePath(possibleTiles.begin(), possibleTiles.end());
@@ -811,7 +811,7 @@ bool CRmgTemplateZone::createTreasurePile (CMapGenerator* gen, int3 &pos, float
 			}
 	}
 
-	if (!treasures.empty())
+	if (!treasures.size())
 	{
 		//find object closest to zone center, then connect it to the middle of the zone
 		int3 closestFreeTile (-1,-1,-1);

From c094e70784bbebd2924063dc2dd6040672530fd9 Mon Sep 17 00:00:00 2001
From: DjWarmonger <Warmonger@vp.pl>
Date: Sat, 22 Nov 2014 12:45:13 +0100
Subject: [PATCH 16/19] Replaced legacy sprintf with boost::format.

---
 client/CPlayerInterface.cpp               |  6 ++----
 client/battle/CBattleInterface.cpp        | 24 ++++++++++-------------
 client/battle/CBattleInterfaceClasses.cpp |  5 ++---
 3 files changed, 14 insertions(+), 21 deletions(-)

diff --git a/client/CPlayerInterface.cpp b/client/CPlayerInterface.cpp
index 380e04ef4..cefc32802 100644
--- a/client/CPlayerInterface.cpp
+++ b/client/CPlayerInterface.cpp
@@ -677,10 +677,8 @@ void CPlayerInterface::battleStacksHealedRes(const std::vector<std::pair<ui32, u
 			CCS->soundh->playSound(soundBase::DRAINLIF);
 
 			//print info about life drain
-			char textBuf[1000];
-			snprintf(textBuf, 1000, CGI->generaltexth->allTexts[361 + textOff].c_str(), attacker->getCreature()->nameSing.c_str(),
-				healedStacks[0].second, defender->getCreature()->namePl.c_str());
-			battleInt->console->addText(textBuf);
+			auto txt =  boost::format (CGI->generaltexth->allTexts[361 + textOff]) %  attacker->getCreature()->nameSing % healedStacks[0].second % defender->getCreature()->namePl;
+			battleInt->console->addText(boost::to_string(txt));
 		}
 	}
 	if (tentHeal)
diff --git a/client/battle/CBattleInterface.cpp b/client/battle/CBattleInterface.cpp
index 22502531e..c5f0041ce 100644
--- a/client/battle/CBattleInterface.cpp
+++ b/client/battle/CBattleInterface.cpp
@@ -831,11 +831,10 @@ void CBattleInterface::bFleef()
 			if(defendingHeroInstance->tempOwner == curInt->cb->getMyColor())
 				heroName = defendingHeroInstance->name;
 		//calculating text
-		char buffer[1000];
-		snprintf(buffer, 1000, CGI->generaltexth->allTexts[340].c_str(), heroName.c_str()); //The Shackles of War are present.  %s can not retreat!
+		auto txt = boost::format(CGI->generaltexth->allTexts[340]) % heroName; //The Shackles of War are present.  %s can not retreat!
 
 		//printing message
-		curInt->showInfoDialog(std::string(buffer), comps);
+		curInt->showInfoDialog(boost::to_string(txt), comps);
 	}
 }
 
@@ -1519,12 +1518,11 @@ void CBattleInterface::battleStacksEffectsSet(const SetStackEffect & sse)
 			if(stack->count != 1)
 				txtid++; //move to plural text
 
-			char txt[4000];
 			BonusList defenseBonuses = *(stack->getBonuses(Selector::typeSubtype(Bonus::PRIMARY_SKILL, PrimarySkill::DEFENSE)));
 			defenseBonuses.remove_if(Selector::durationType(Bonus::STACK_GETS_TURN)); //remove bonuses gained from defensive stance
 			int val = stack->Defense() - defenseBonuses.totalValue();
-			snprintf(txt, 4000, CGI->generaltexth->allTexts[txtid].c_str(),  (stack->count != 1) ? stack->getCreature()->namePl.c_str() : stack->getCreature()->nameSing.c_str(), val);
-			console->addText(txt);
+			auto txt = boost::format (CGI->generaltexth->allTexts[txtid]) % ((stack->count != 1) ? stack->getCreature()->namePl : stack->getCreature()->nameSing) % val;
+			console->addText(boost::to_string(txt));
 		}
 	}
 
@@ -1793,28 +1791,26 @@ void CBattleInterface::getPossibleActionsForStack(const CStack * stack)
 
 void CBattleInterface::printConsoleAttacked( const CStack * defender, int dmg, int killed, const CStack * attacker, bool multiple )
 {
-	char tabh[200] = {0};
+	boost::format txt;
 	int end = 0;
 	if (attacker) //ignore if stacks were killed by spell
 	{
-		end = snprintf(tabh, 200, CGI->generaltexth->allTexts[attacker->count > 1 ? 377 : 376].c_str(),
-		(attacker->count > 1 ? attacker->getCreature()->namePl.c_str() : attacker->getCreature()->nameSing.c_str()), dmg);
+		txt = boost::format (CGI->generaltexth->allTexts[attacker->count > 1 ? 377 : 376]) %
+			(attacker->count > 1 ? attacker->getCreature()->namePl : attacker->getCreature()->nameSing) % dmg;
 	}
 	if(killed > 0)
 	{
 		if(killed > 1)
 		{
-			snprintf(tabh + end, 400, CGI->generaltexth->allTexts[379].c_str(), killed,
-				multiple ? CGI->generaltexth->allTexts[43].c_str() : defender->getCreature()->namePl.c_str()); // creatures perish
+			txt = boost::format (CGI->generaltexth->allTexts[379]) % killed % (multiple ? CGI->generaltexth->allTexts[43] : defender->getCreature()->namePl); // creatures perish
 		}
 		else //killed == 1
 		{
-			snprintf(tabh + end, 400, CGI->generaltexth->allTexts[378].c_str(),
-				multiple ? CGI->generaltexth->allTexts[42].c_str() : defender->getCreature()->nameSing.c_str()); // creature perishes
+			txt = boost::format (CGI->generaltexth->allTexts[378]) % (multiple ? CGI->generaltexth->allTexts[42] : defender->getCreature()->nameSing); // creature perishes
 		}
 	}
 
-	console->addText(std::string(tabh));
+	console->addText(boost::to_string (txt));
 }
 
 
diff --git a/client/battle/CBattleInterfaceClasses.cpp b/client/battle/CBattleInterfaceClasses.cpp
index 1f64bee80..f08e79b69 100644
--- a/client/battle/CBattleInterfaceClasses.cpp
+++ b/client/battle/CBattleInterfaceClasses.cpp
@@ -577,10 +577,9 @@ void CClickableHex::mouseMoved(const SDL_MouseMotionEvent &sEvent)
 			attackedStack->owner != myInterface->getCurrentPlayerInterface()->playerID &&
 			attackedStack->alive())
 		{
-			char tabh[160];
 			const std::string & attackedName = attackedStack->count == 1 ? attackedStack->getCreature()->nameSing : attackedStack->getCreature()->namePl;
-			snprintf(tabh, 160, CGI->generaltexth->allTexts[220].c_str(), attackedName.c_str());
-			myInterface->console->alterTxt = std::string(tabh);
+			auto txt = boost::format (CGI->generaltexth->allTexts[220]) % attackedName;
+			myInterface->console->alterTxt = boost::to_string(txt);
 			setAlterText = true;
 		}
 	}

From 91d89add7c8c64e8851a837e26aba32fdf3963a7 Mon Sep 17 00:00:00 2001
From: DjWarmonger <Warmonger@vp.pl>
Date: Sat, 22 Nov 2014 13:01:28 +0100
Subject: [PATCH 17/19] Reverted RMG bug introduced in
 https://github.com/vcmi/vcmi/commit/6da79d01d7f3c6ddf268173e10b07f4f4ee6378e

---
 lib/rmg/CRmgTemplateZone.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/rmg/CRmgTemplateZone.cpp b/lib/rmg/CRmgTemplateZone.cpp
index 7b838dec9..d5313e0f3 100644
--- a/lib/rmg/CRmgTemplateZone.cpp
+++ b/lib/rmg/CRmgTemplateZone.cpp
@@ -811,7 +811,7 @@ bool CRmgTemplateZone::createTreasurePile (CMapGenerator* gen, int3 &pos, float
 			}
 	}
 
-	if (!treasures.size())
+	if (treasures.size())
 	{
 		//find object closest to zone center, then connect it to the middle of the zone
 		int3 closestFreeTile (-1,-1,-1);

From 9e5cc2d1b156c2bc8413d590b81b25ba04b1063c Mon Sep 17 00:00:00 2001
From: DjWarmonger <Warmonger@vp.pl>
Date: Sat, 22 Nov 2014 14:17:53 +0100
Subject: [PATCH 18/19] Treasure piles will prefer to grow upwards to make
 space for object accessible from bottom.

---
 lib/rmg/CRmgTemplateZone.cpp | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lib/rmg/CRmgTemplateZone.cpp b/lib/rmg/CRmgTemplateZone.cpp
index d5313e0f3..44c663fb6 100644
--- a/lib/rmg/CRmgTemplateZone.cpp
+++ b/lib/rmg/CRmgTemplateZone.cpp
@@ -787,7 +787,12 @@ bool CRmgTemplateZone::createTreasurePile (CMapGenerator* gen, int3 &pos, float
 
 			//randomize next position from among possible ones
 			std::vector<int3> boundaryCopy (boundary.begin(), boundary.end());
-			RandomGeneratorUtil::randomShuffle(boundaryCopy, gen->rand);
+			//RandomGeneratorUtil::randomShuffle(boundaryCopy, gen->rand);
+			auto chooseTopTile = [](const int3 & lhs, const int3 & rhs) -> bool
+			{
+				return lhs.y < rhs.y;
+			};
+			boost::sort(boundaryCopy, chooseTopTile); //start from top tiles to allow objects accessible from bottom
 
 			for (auto tile : boundaryCopy)
 			{

From 6fd0f76547241331bd7a93f8a23cfce64d679446 Mon Sep 17 00:00:00 2001
From: ArseniyShestakov <ArseniyShestakov@users.noreply.github.com>
Date: Sun, 23 Nov 2014 08:51:48 +0300
Subject: [PATCH 19/19] Fix invisible save select when click on save name area

---
 client/CPreGame.cpp | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/client/CPreGame.cpp b/client/CPreGame.cpp
index 6eb0a6725..049f5ae72 100644
--- a/client/CPreGame.cpp
+++ b/client/CPreGame.cpp
@@ -1586,7 +1586,14 @@ int SelectionTab::getLine()
 	Point clickPos(GH.current->button.x, GH.current->button.y);
 	clickPos = clickPos - pos.topLeft();
 
-	if (clickPos.y > 115  &&  clickPos.y < 564  &&  clickPos.x > 22  &&  clickPos.x < 371)
+	// Ignore clicks on save name area
+	int maxPosY;
+	if(tabType == CMenuScreen::saveGame)
+		maxPosY = 516;
+	else
+		maxPosY = 564;
+
+    	if(clickPos.y > 115  &&  clickPos.y < maxPosY  &&  clickPos.x > 22  &&  clickPos.x < 371)
 	{
 		line = (clickPos.y-115) / 25; //which line
 	}