1
0
mirror of https://github.com/vcmi/vcmi.git synced 2025-03-21 21:17:49 +02:00

Bonus system: use duration helpers in selecters

This commit is contained in:
ArseniyShestakov 2015-11-20 13:24:48 +03:00
parent 6d395bcba7
commit f99ffbd074

View File

@ -811,7 +811,7 @@ public:
bool operator()(const Bonus *bonus) const
{
return turnsRequested <= 0 //every present effect will last zero (or "less") turns
|| !(bonus->duration & Bonus::N_TURNS) //so do every not expriing after N-turns effect
|| !Bonus::NTurns(bonus) //so do every not expriing after N-turns effect
|| bonus->turnsRemain > turnsRequested;
}
CWillLastTurns& operator()(const int &setVal)
@ -828,11 +828,11 @@ public:
bool operator()(const Bonus *bonus) const
{
if(daysRequested <= 0 || bonus->duration & Bonus::PERMANENT || bonus->duration & Bonus::ONE_BATTLE)
if(daysRequested <= 0 || Bonus::Permanent(bonus) || Bonus::OneBattle(bonus))
return true;
else if(bonus->duration & Bonus::ONE_DAY)
else if(Bonus::OneDay(bonus))
return false;
else if(bonus->duration & Bonus::N_DAYS || bonus->duration & Bonus::ONE_WEEK)
else if(Bonus::NDays(bonus) || Bonus::OneWeek(bonus))
{
return bonus->turnsRemain > daysRequested;
}