games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-06-25 00:37:24 +02:00
Code Issues Releases Activity

Fix installation of multiple mods at once

Browse Source
This commit is contained in:
Ivan Savenko
2024-11-19 22:15:05 +00:00
parent 00f97fb8cd
commit fef19f4846
7 changed files with 52 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
lib/modding/ModManager.cpp
View File

@ -495,24 +495,34 @@ TModList ModManager::collectDependenciesRecursive(const TModID & modID) const
return result;
}
void ModManager::tryEnableMod(const TModID & modName)
void ModManager::tryEnableMods(const TModList & modList)
{
auto requiredActiveMods = collectDependenciesRecursive(modName);
auto additionalActiveMods = getActiveMods();
TModList requiredActiveMods;
TModList additionalActiveMods = getActiveMods();
assert(!vstd::contains(additionalActiveMods, modName));
assert(vstd::contains(requiredActiveMods, modName));// FIXME: fails on attempt to enable broken mod / translation to other language
for (const auto & modName : modList)
{
for (const auto & dependency : collectDependenciesRecursive(modName))
if (!vstd::contains(requiredActiveMods, dependency))
requiredActiveMods.push_back(dependency);
assert(!vstd::contains(additionalActiveMods, modName));
assert(vstd::contains(requiredActiveMods, modName));// FIXME: fails on attempt to enable broken mod / translation to other language
}
ModDependenciesResolver testResolver(requiredActiveMods, *modsStorage);
assert(testResolver.getBrokenMods().empty());
assert(vstd::contains(testResolver.getActiveMods(), modName));
testResolver.tryAddMods(additionalActiveMods, *modsStorage);
if (!vstd::contains(testResolver.getActiveMods(), modName))
for (const auto & modName : modList)
{
// FIXME: report?
return;
assert(vstd::contains(testResolver.getActiveMods(), modName));
if (!vstd::contains(testResolver.getActiveMods(), modName))
{
// FIXME: report?
return;
}
}
updatePreset(testResolver);