Ivan Savenko
fe276374ef
Merge pull request #5687 from kdmcser/fix_commander_artifacts
...
fix commander artifacts inactive when loading game
2025-05-06 16:20:27 +03:00
kdmcser
aebe4932fb
fix commander artifacts inactive when loading game
2025-05-05 23:01:43 +08:00
Ivan Savenko
fb0cdb2475
Merge pull request #5669 from IvanSavenko/haven_fix
...
Fix crash on evaluating creature terrain limiter during initialization (Haven mod fix)
2025-05-05 16:18:54 +03:00
Ivan Savenko
1690913ba4
Stack instance now stores non-serialized pointer to army
2025-05-05 16:09:21 +03:00
Ivan Savenko
90e765b2be
Merge pull request #5677 from kdmcser/hang_fix
...
fix hangs after a siege battle
2025-05-05 16:06:25 +03:00
kdmcser
50887a4f30
fix hangs after a siege battle
2025-05-02 22:16:35 +08:00
Ivan Savenko
283adc37d7
Unit stack rebalancing rework
...
- CStackInstance::count is now private with accessor methods
- CStackInstance::experience renamed to totalExperience and now stores
total stack experience (multiplied by stack size) to reduce rounding
errors
- CStackInstance::totalExperience is now private with accessors methods
- stack experience is now automatically reallocated on stack management
- Removed buggy BulkSmartRebalanceStacks pack, that mostly duplicates
BulkRebalanceStacks
- Renamed BulkSmartSplitStack to BulkSplitAndRebalanceStack to drop
unclear "smart" in name
- Reworked split-and-rebalance logic to correctly reallocate stack
experience
2025-05-01 18:18:30 +03:00
Ivan Savenko
ac26b3ed9b
Merge pull request #5658 from IvanSavenko/memleak_fix
...
Fix discovered memory leaks & reduce usage of raw pointers
2025-04-30 13:38:37 +03:00
Ivan Savenko
f70ad2c15b
Reorganized artifact-related classes
...
- files now generally contain only 1 class (except for tightly coupled
classes)
- files are now located in lib/entities/artifact directory
- removed excessive includes
No changes to functionality
2025-04-29 13:29:08 +03:00
Ivan Savenko
c0fb1d1b3b
Replace some raw pointers with unique's or optional
2025-04-29 12:11:10 +03:00
Ivan Savenko
4e8e85e3e4
Fix issues reported by Sonar, review fixes
2025-04-27 14:57:31 +03:00
Ivan Savenko
829739da24
Reduce usage of implicit conversions to int
2025-04-27 14:57:31 +03:00
Ivan Savenko
4d57a8ed36
Prefer to pass CGameState as reference instead of pointer
2025-04-27 14:57:31 +03:00
Ivan Savenko
a43c3fcb31
Restore save compatibility with 1.6
2025-04-27 14:57:31 +03:00
Ivan Savenko
f025a3a932
Review & cleanup hiding / displaying map objects
2025-04-27 14:57:31 +03:00
Ivan Savenko
912c2eae94
Fix regressions
2025-04-27 14:57:31 +03:00
Ivan Savenko
e6a8e5d4bd
Correctly restore bonus system on deserialization
2025-04-27 14:57:31 +03:00
Ivan Savenko
93b18ee94b
Fix some issues detected by Sonar & code review, fix build
2025-04-27 14:57:31 +03:00
Ivan Savenko
d1d2cf4189
Fix crashes on game start, gamestate now derives from GameCallbackHolder
2025-04-27 14:57:31 +03:00
Ivan Savenko
d34b47bb20
Remove pointers from artifacts
2025-04-27 14:57:31 +03:00
Ivan Savenko
4ed13409c2
Remove serialization of raw pointers from serialization
2025-04-27 14:57:31 +03:00
Ivan Savenko
9e6397d1f9
Remove pointer to boat from CGHeroInstance
2025-04-27 14:57:30 +03:00
Ivan Savenko
6d65641a43
Gamestate is now passed as shared pointer
2025-04-27 14:57:30 +03:00
Ivan Savenko
cd7732456a
Remove pointer to objects from TerrainTile
2025-04-27 14:57:30 +03:00
Ivan Savenko
63d00b080e
Removed pointer to army from StackInstance
2025-04-27 14:57:30 +03:00
Ivan Savenko
16a06179cf
Use ArtifactInstanceID in CGArtifact
2025-04-27 14:57:30 +03:00
Ivan Savenko
ab11d2b075
Remove quests from CMap, now solely owned by quest objects
2025-04-27 14:57:30 +03:00
Ivan Savenko
c02a8a84fd
Stacks of armed instance are now unique_ptr
2025-04-27 14:57:30 +03:00
Ivan Savenko
bdae7285ae
Objects list is now private member of CMap
2025-04-27 14:57:30 +03:00
Ivan Savenko
745040def3
Access to heroes storage in CMap is now done via public methods
2025-04-27 14:57:30 +03:00
Ivan Savenko
0ada2a5ebd
Map objects now use shared_ptr (game)
2025-04-27 14:57:30 +03:00
Ivan Savenko
2ca1748e96
Artifact instances are now owned solely by CMap
2025-04-27 14:57:30 +03:00
Ivan Savenko
797646cc05
Quests in map now use shared_ptr instead of const ptr
2025-04-27 14:57:30 +03:00
Ivan Savenko
417ea6451a
Remove ConstTransitivePtr from hero and town instances
2025-04-27 14:57:30 +03:00
Michał Zaremba
63906c4446
Fix bug when no casualties but 1 skeleton is raised
2025-04-23 13:45:21 +02:00
Ivan Savenko
ce89a0d21b
Merge pull request #5609 from SoundSSGood/end-of-battle-infowindows
...
End of battle infowindows refactoring
2025-04-15 22:50:35 +03:00
Ivan Savenko
83099f9288
Fix crash on initializing off-map hero
2025-04-13 23:15:49 +03:00
Ivan Savenko
2b812be9cd
Correctly show results of CreatureTerrainLimiter outside of combat
2025-04-13 22:23:12 +03:00
SoundSSGood
60afbbe20f
Necromancy & Eagle eye infowindows
2025-04-09 10:13:10 +02:00
SoundSSGood
603672ff51
revert some changes
2025-04-07 17:00:24 +02:00
Ben Fradet
f18715bd48
Update lib/mapObjects/CGDwelling.cpp
...
Co-authored-by: Ivan Savenko <saven.ivan@gmail.com >
2025-03-30 20:09:57 +02:00
benfradet
dc1358a416
Fix dwellings recruitment text
2025-03-29 23:31:01 +01:00
Ivan Savenko
33f708c744
Merge pull request #5577 from GeorgeK1ng/skill_removal
...
Skill removal as reward
2025-03-26 16:47:37 +02:00
Ivan Savenko
dfbe6d1965
Merge pull request #5572 from IvanSavenko/old_banks_remove
...
Remove deprecated support for banks in 1.5 format
2025-03-26 16:45:56 +02:00
George King
474e044caf
Update lib/mapObjects/CGHeroInstance.cpp
...
Co-authored-by: Ivan Savenko <saven.ivan@gmail.com >
2025-03-22 18:25:30 +01:00
George King
cae84e0e77
Skill removal as reward
2025-03-22 17:16:46 +01:00
Ivan Savenko
7a3e1409d0
Remove old boost includes and defines
2025-03-19 08:03:56 +00:00
Ivan Savenko
2b286378e8
Remove logic for banks in 1.5 format
2025-03-19 08:02:39 +00:00
Ivan Savenko
eb3b51a6cf
Remove save compatibility with 1.5.X
2025-03-18 11:35:15 +00:00
Ivan Savenko
6877bbfe3a
Fix issues found by Valgrind
2025-03-12 15:56:52 +00:00
