games/vcmi
1
0
Fork 0
mirror of https://github.com/vcmi/vcmi.git synced 2025-04-07 07:10:04 +02:00
Code Issues Releases Activity
vcmi/AI/Nullkiller/Goals
History
Sergei Trofimovich c2c352c6dd AI/Nullkiller/Goals/ExecuteHeroChain.cpp: catch polymorphic exceptions by reference 
The suspicious code was detected by `gcc-13` as:

    AI/Nullkiller/Goals/ExecuteHeroChain.cpp: In member function 'virtual void NKAI::Goals::ExecuteHeroChain::accept(NKAI::AIGateway*)':
    AI/Nullkiller/Goals/ExecuteHeroChain.cpp:130:47: warning: catching polymorphic type 'class NKAI::cannotFulfillGoalException' by value [-Wcatch-value=]
      130 |                                         catch(cannotFulfillGoalException)
          |                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~
    AI/Nullkiller/Goals/ExecuteHeroChain.cpp:176:23: warning: catching polymorphic type 'class NKAI::goalFulfilledException' by value [-Wcatch-value=]
      176 |                 catch(goalFulfilledException)
          |                       ^~~~~~~~~~~~~~~~~~~~~~

Similar to object passing by value and reference passing polymorphic
exceptions by reference likely destroys them when copy-constructed to
a base class. Let's catch them by reference.
2022-12-17 21:50:57 +00:00
..
AbstractGoal.cpp
NKAI: namespace
2022-10-04 08:40:14 +03:00
AbstractGoal.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
AdventureSpellCast.cpp
NKAI: namespace
2022-10-04 08:40:14 +03:00
AdventureSpellCast.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
Build.cpp
NKAI: namespace
2022-10-04 08:40:14 +03:00
Build.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
BuildBoat.cpp
NKAI: namespace
2022-10-04 08:40:14 +03:00
BuildBoat.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
BuildThis.cpp
NKAI: namespace
2022-10-04 08:40:14 +03:00
BuildThis.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
BuyArmy.cpp
NKAI: namespace
2022-10-04 08:40:14 +03:00
BuyArmy.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
CaptureObject.cpp
NKAI: namespace
2022-10-04 08:40:14 +03:00
CaptureObject.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
CGoal.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
CompleteQuest.cpp
NKAI: namespace
2022-10-04 08:40:14 +03:00
CompleteQuest.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
Composition.cpp
NKAI: namespace
2022-10-04 08:40:14 +03:00
Composition.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
DigAtTile.cpp
NKAI: namespace
2022-10-04 08:40:14 +03:00
DigAtTile.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
DismissHero.cpp
NKAI: namespace
2022-10-04 08:40:14 +03:00
DismissHero.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
ExchangeSwapTownHeroes.cpp
NKAI: namespace
2022-10-04 08:40:14 +03:00
ExchangeSwapTownHeroes.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
ExecuteHeroChain.cpp
AI/Nullkiller/Goals/ExecuteHeroChain.cpp: catch polymorphic exceptions by reference
2022-12-17 21:50:57 +00:00
ExecuteHeroChain.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
GatherArmy.cpp
NKAI: namespace
2022-10-04 08:40:14 +03:00
GatherArmy.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
Goals.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
Invalid.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
RecruitHero.cpp
NKAI: fix retreat logic
2022-10-15 15:15:12 +03:00
RecruitHero.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
SaveResources.cpp
NKAI: namespace
2022-10-04 08:40:14 +03:00
SaveResources.h
NKAI: namespace
2022-10-04 08:40:14 +03:00
Trade.cpp
NKAI: namespace
2022-10-04 08:40:14 +03:00
Trade.h
NKAI: namespace
2022-10-04 08:40:14 +03:00