remember: Context+Request separation ripple

- Re-add the age-old "Values" from the Context. This was originally
  there for exactly the documented purpose. However the Context holding
  the request form values negated it's use. It's back because of this
  new separation.
- Make the auth success path set the authboss.CookieRemember value in
  the context before calling it's callback.

auth/auth.go

@@ -120,6 +120,7 @@ func (a *Auth) loginHandlerFunc(ctx *authboss.Context, w http.ResponseWriter, r
 
 		ctx.SessionStorer.Put(authboss.SessionKey, key)
 		ctx.SessionStorer.Del(authboss.SessionHalfAuthKey)
+		ctx.Values = map[string]string{authboss.CookieRemember: r.FormValue(authboss.CookieRemember)}
 
 		if err := a.Callbacks.FireAfter(authboss.EventAuth, ctx); err != nil {
 			return err

auth/auth_test.go

@@ -239,6 +239,9 @@ func TestAuth_loginHandlerFunc_POST(t *testing.T) {
 		t.Error("Unexpected error:", err)
 	}
 
+	if _, ok := ctx.Values[authboss.CookieRemember]; !ok {
+		t.Error("Authboss cookie remember should be set for the callback")
+	}
 	if !cb.HasBeenCalled {
 		t.Error("Expected after callback to have been called")
 	}

context.go

@@ -20,6 +20,9 @@ type Context struct {
 	SessionStorer ClientStorerErr
 	CookieStorer  ClientStorerErr
 	User          Attributes
+
+	// Values is a free-form key-value store to pass data to callbacks
+	Values map[string]string
 }
 
 // NewContext is exported for testing modules.

recover/recover.go

@@ -144,7 +144,7 @@ func (rec *Recover) startHandlerFunc(ctx *authboss.Context, w http.ResponseWrite
 		)
 
 		policies := authboss.FilterValidators(rec.Policies, rec.PrimaryID)
-		if validationErrs := ctx.Validate(r, policies, rec.PrimaryID, authboss.ConfirmPrefix+rec.PrimaryID).Map(); len(validationErrs) > 0 {
+		if validationErrs := authboss.Validate(r, policies, rec.PrimaryID, authboss.ConfirmPrefix+rec.PrimaryID).Map(); len(validationErrs) > 0 {
 			errData.MergeKV("errs", validationErrs)
 			return rec.templates.Render(ctx, w, r, tplRecover, errData)
 		}
@@ -237,7 +237,7 @@ func (r *Recover) completeHandlerFunc(ctx *authboss.Context, w http.ResponseWrit
 		//confirmPassword, _ := ctx.FirstPostFormValue("confirmPassword")
 
 		policies := authboss.FilterValidators(r.Policies, authboss.StorePassword)
-		if validationErrs := ctx.Validate(req, policies, authboss.StorePassword, authboss.ConfirmPrefix+authboss.StorePassword).Map(); len(validationErrs) > 0 {
+		if validationErrs := authboss.Validate(req, policies, authboss.StorePassword, authboss.ConfirmPrefix+authboss.StorePassword).Map(); len(validationErrs) > 0 {
 			data := authboss.NewHTMLData(
 				formValueToken, token,
 				"errs", validationErrs,

remember/remember.go

@@ -83,7 +83,7 @@ func (r *Remember) Storage() authboss.StorageOptions {
 
 // afterAuth is called after authentication is successful.
 func (r *Remember) afterAuth(ctx *authboss.Context) error {
-	if val, ok := ctx.FirstPostFormValue(authboss.CookieRemember); !ok || val != "true" {
+	if val := ctx.Values[authboss.CookieRemember]; val != "true" {
 		return nil
 	}
 

remember/remember_test.go

@@ -2,7 +2,6 @@ package remember
 
 import (
 	"bytes"
-	"fmt"
 	"net/http"
 	"testing"
 
@@ -49,15 +48,13 @@ func TestAfterAuth(t *testing.T) {
 	}
 	req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
 
-	ctx, err := r.ContextFromRequest(req)
-	if err != nil {
-		t.Error("Unexpected error:", err)
-	}
-
+	ctx := r.NewContext()
 	ctx.SessionStorer = session
 	ctx.CookieStorer = cookies
 	ctx.User = authboss.Attributes{r.PrimaryID: "test@email.com"}
 
+	ctx.Values = map[string]string{authboss.CookieRemember: "true"}
+
 	if err := r.afterAuth(ctx); err != nil {
 		t.Error(err)
 	}
@@ -77,17 +74,7 @@ func TestAfterOAuth(t *testing.T) {
 	cookies := mocks.NewMockClientStorer()
 	session := mocks.NewMockClientStorer(authboss.SessionOAuth2Params, `{"rm":"true"}`)
 
-	uri := fmt.Sprintf("%s?state=%s", "localhost/oauthed", "xsrf")
-	req, err := http.NewRequest("GET", uri, nil)
-	if err != nil {
-		t.Error("Unexpected Error:", err)
-	}
-
-	ctx, err := r.ContextFromRequest(req)
-	if err != nil {
-		t.Error("Unexpected error:", err)
-	}
-
+	ctx := r.NewContext()
 	ctx.SessionStorer = session
 	ctx.CookieStorer = cookies
 	ctx.User = authboss.Attributes{