go/echo
1
0
Fork 0
mirror of https://github.com/labstack/echo.git synced 2025-12-01 22:51:17 +02:00
Code Issues Releases Activity

Adding sync.Pool to Decompress middleware

Browse Source 
Fixing a http.Request.Body leak on the decompress middleware that were
not properly Close
Removing the defer on the call to gzip.Reader, because that reader is
already exausted after the call to io.Copy
This commit is contained in:
Pablo Andres Fuente
2020-11-27 03:01:04 +00:00
parent 502cce28d5
commit 14e020bc07
2 changed files with 46 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
middleware/compress.go
View File

@@ -59,7 +59,7 @@ func GzipWithConfig(config GzipConfig) echo.MiddlewareFunc {
config.Level = DefaultGzipConfig.Level
}
pool := gzipPool(config)
pool := gzipCompressPool(config)
return func(next echo.HandlerFunc) echo.HandlerFunc {
return func(c echo.Context) error {
@@ -133,7 +133,7 @@ func (w *gzipResponseWriter) Push(target string, opts *http.PushOptions) error {
return http.ErrNotSupported
}
func gzipPool(config GzipConfig) sync.Pool {
func gzipCompressPool(config GzipConfig) sync.Pool {
return sync.Pool{
New: func() interface{} {
w, err := gzip.NewWriterLevel(ioutil.Discard, config.Level)