go/echo
1
0
Fork 0
mirror of https://github.com/labstack/echo.git synced 2025-07-15 01:34:53 +02:00
Code Issues Releases Activity

Add cookie tag for logger (#921)

Browse Source 
Thanks for your contribution 🎉
This commit is contained in:
aruhi
2017-05-09 00:10:11 +09:00
committed by Vishal Rana
parent 533d7a8dc1
commit 1827916e76
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
middleware/logger.go
View File

@ -183,6 +183,11 @@ func LoggerWithConfig(config LoggerConfig) echo.MiddlewareFunc {
return buf.Write([]byte(c.QueryParam(tag[6:]))) return buf.Write([]byte(c.QueryParam(tag[6:])))
case strings.HasPrefix(tag, "form:"): case strings.HasPrefix(tag, "form:"):
return buf.Write([]byte(c.FormValue(tag[5:]))) return buf.Write([]byte(c.FormValue(tag[5:])))
case strings.HasPrefix(tag, "cookie:"):
cookie, err := c.Cookie(tag[7:])
if err == nil {
return buf.Write([]byte(cookie.Value))
}
} }
} }
return 0, nil return 0, nil

4
middleware/logger_test.go
View File

@ -90,7 +90,7 @@ func TestLoggerTemplate(t *testing.T) {
`"method":"${method}","uri":"${uri}","status":${status}, "latency":${latency},` + `"method":"${method}","uri":"${uri}","status":${status}, "latency":${latency},` +
`"latency_human":"${latency_human}","bytes_in":${bytes_in}, "path":"${path}", "referer":"${referer}",` + `"latency_human":"${latency_human}","bytes_in":${bytes_in}, "path":"${path}", "referer":"${referer}",` +
`"bytes_out":${bytes_out},"ch":"${header:X-Custom-Header}",` + `"bytes_out":${bytes_out},"ch":"${header:X-Custom-Header}",` +
`"us":"${query:username}", "cf":"${form:username}"}` + "\n", `"us":"${query:username}", "cf":"${form:username}", "session":"${cookie:session}"}` + "\n",
Output: buf, Output: buf,
})) }))
@ -105,6 +105,7 @@ func TestLoggerTemplate(t *testing.T) {
req.Header.Add("User-Agent", "echo-tests-agent") req.Header.Add("User-Agent", "echo-tests-agent")
req.Header.Add("X-Custom-Header", "AAA-CUSTOM-VALUE") req.Header.Add("X-Custom-Header", "AAA-CUSTOM-VALUE")
req.Header.Add("X-Request-ID", "6ba7b810-9dad-11d1-80b4-00c04fd430c8") req.Header.Add("X-Request-ID", "6ba7b810-9dad-11d1-80b4-00c04fd430c8")
req.Header.Add("Cookie", "_ga=GA1.2.000000000.0000000000; session=ac08034cd216a647fc2eb62f2bcf7b810")
req.Form = url.Values{ req.Form = url.Values{
"username": []string{"apagano-form"}, "username": []string{"apagano-form"},
"password": []string{"secret-form"}, "password": []string{"secret-form"},
@ -129,6 +130,7 @@ func TestLoggerTemplate(t *testing.T) {
"google.com": true, "google.com": true,
"echo-tests-agent": true, "echo-tests-agent": true,
"6ba7b810-9dad-11d1-80b4-00c04fd430c8": true, "6ba7b810-9dad-11d1-80b4-00c04fd430c8": true,
"ac08034cd216a647fc2eb62f2bcf7b810": true,
} }
for token, present := range cases { for token, present := range cases {