go/echo
1
0
Fork 0
mirror of https://github.com/labstack/echo.git synced 2025-06-25 00:47:01 +02:00
Code Issues Releases Activity

Dropped support for func(http.Handler) http.Handler middleware

Browse Source 
Signed-off-by: Vishal Rana <vr@labstack.com>
This commit is contained in:
Vishal Rana
2015-04-19 16:00:23 -07:00
parent 54824fc22f
commit 3eeea660fa
10 changed files with 52 additions and 156 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
echo_test.go
View File

@ -84,21 +84,21 @@ func TestEchoMiddleware(t *testing.T) {
})))
// func(http.Handler) http.Handler
e.Use(func(h http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
b.WriteString("f")
h.ServeHTTP(w, r)
})
})
// e.Use(func(h http.Handler) http.Handler {
// return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
// b.WriteString("f")
// h.ServeHTTP(w, r)
// })
// })
// func(http.ResponseWriter, *http.Request)
e.Use(func(w http.ResponseWriter, r *http.Request) {
b.WriteString("g")
b.WriteString("f")
})
// func(http.ResponseWriter, *http.Request) error
e.Use(func(w http.ResponseWriter, r *http.Request) error {
b.WriteString("h")
b.WriteString("g")
return nil
})
@ -110,8 +110,8 @@ func TestEchoMiddleware(t *testing.T) {
w := httptest.NewRecorder()
r, _ := http.NewRequest(GET, "/hello", nil)
e.ServeHTTP(w, r)
if b.String() != "abcdefgh" {
t.Errorf("buffer should be abcdefgh, found %s", b.String())
if b.String() != "abcdefg" {
t.Errorf("buffer should be abcdefg, found %s", b.String())
}
if w.Body.String() != "world" {
t.Error("body should be world")