go/echo
go/echo
1
0
Fork 0
mirror of https://github.com/labstack/echo.git synced 2025-06-08 23:56:20 +02:00
Code Issues Releases Activity

change the hardcode for http constant

Browse Source
This commit is contained in:
yonbiaoxiao 2020-08-23 11:18:31 +08:00
parent 28ec3f7bdb
commit 5c5c83d290
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
middleware/rewrite_test.go
View File

@ -42,11 +42,11 @@ func TestRewrite(t *testing.T) {
rec = httptest.NewRecorder() rec = httptest.NewRecorder()
e.ServeHTTP(rec, req) e.ServeHTTP(rec, req)
assert.Equal(t, "/new%20users", req.URL.EscapedPath()) assert.Equal(t, "/new%20users", req.URL.EscapedPath())
req.URL.Path = "/users/jill/orders/T%2FcO4lW%2Ft%2FVp%2F" req.URL.Path = "/users/jill/orders/T%2FcO4lW%2Ft%2FVp%2F"
rec = httptest.NewRecorder() rec = httptest.NewRecorder()
e.ServeHTTP(rec, req) e.ServeHTTP(rec, req)
assert.Equal(t, "/user/jill/order/T%2FcO4lW%2Ft%2FVp%2F", req.URL.EscapedPath()) assert.Equal(t, "/user/jill/order/T%2FcO4lW%2Ft%2FVp%2F", req.URL.EscapedPath())
req.URL.Path = "/users/jill/orders/%%%%" req.URL.Path = "/users/jill/orders/%%%%"
rec = httptest.NewRecorder() rec = httptest.NewRecorder()
e.ServeHTTP(rec, req) e.ServeHTTP(rec, req)
assert.Equal(t, http.StatusBadRequest, rec.Code) assert.Equal(t, http.StatusBadRequest, rec.Code)
@ -66,14 +66,14 @@ func TestEchoRewritePreMiddleware(t *testing.T) {
// Route // Route
r.Add(http.MethodGet, "/new", func(c echo.Context) error { r.Add(http.MethodGet, "/new", func(c echo.Context) error {
return c.NoContent(200) return c.NoContent(http.StatusOK)
}) })
req := httptest.NewRequest(http.MethodGet, "/old", nil) req := httptest.NewRequest(http.MethodGet, "/old", nil)
rec := httptest.NewRecorder() rec := httptest.NewRecorder()
e.ServeHTTP(rec, req) e.ServeHTTP(rec, req)
assert.Equal(t, "/new", req.URL.EscapedPath()) assert.Equal(t, "/new", req.URL.EscapedPath())
assert.Equal(t, 200, rec.Code) assert.Equal(t, http.StatusOK, rec.Code)
} }
// Issue #1143 // Issue #1143
@ -89,10 +89,10 @@ func TestRewriteWithConfigPreMiddleware_Issue1143(t *testing.T) {
})) }))
r.Add(http.MethodGet, "/api/:version/hosts/:name", func(c echo.Context) error { r.Add(http.MethodGet, "/api/:version/hosts/:name", func(c echo.Context) error {
return c.String(200, "hosts") return c.String(http.StatusOK, "hosts")
}) })
r.Add(http.MethodGet, "/api/:version/eng", func(c echo.Context) error { r.Add(http.MethodGet, "/api/:version/eng", func(c echo.Context) error {
return c.String(200, "eng") return c.String(http.StatusOK, "eng")
}) })
for i := 0; i < 100; i++ { for i := 0; i < 100; i++ {
@ -100,7 +100,7 @@ func TestRewriteWithConfigPreMiddleware_Issue1143(t *testing.T) {
rec := httptest.NewRecorder() rec := httptest.NewRecorder()
e.ServeHTTP(rec, req) e.ServeHTTP(rec, req)
assert.Equal(t, "/api/v1/hosts/test", req.URL.EscapedPath()) assert.Equal(t, "/api/v1/hosts/test", req.URL.EscapedPath())
assert.Equal(t, 200, rec.Code) assert.Equal(t, http.StatusOK, rec.Code)
defer rec.Result().Body.Close() defer rec.Result().Body.Close()
bodyBytes, _ := ioutil.ReadAll(rec.Result().Body) bodyBytes, _ := ioutil.ReadAll(rec.Result().Body)