go/echo
1
0
Fork 0
mirror of https://github.com/labstack/echo.git synced 2025-12-01 22:51:17 +02:00
Code Issues Releases Activity

Proper colon support in reverse (#2416)

Browse Source 
* Adds support of the escaped colon in echo.Reverse

---------

Co-authored-by: Mihard <mihard@webird.ru>
This commit is contained in:
Mihard
2023-04-16 20:13:47 +02:00
committed by GitHub
parent de1c798143
commit 7d54690cdc
2 changed files with 95 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
router.go
View File

@@ -159,7 +159,12 @@ func (r *Router) Reverse(name string, params ...interface{}) string {
for _, route := range r.routes {
if route.Name == name {
for i, l := 0, len(route.Path); i < l; i++ {
if (route.Path[i] == ':' || route.Path[i] == '*') && n < ln {
hasBackslash := route.Path[i] == '\\'
if hasBackslash && i+1 < l && route.Path[i+1] == ':' {
i++ // backslash before colon escapes that colon. in that case skip backslash
}
if n < ln && (route.Path[i] == '*' || (!hasBackslash && route.Path[i] == ':')) {
// in case of `*` wildcard or `:` (unescaped colon) param we replace everything till next slash or end of path
for ; i < l && route.Path[i] != '/'; i++ {
}
uri.WriteString(fmt.Sprintf("%v", params[n]))