go/echo
go/echo
1
0
Fork 0
mirror of https://github.com/labstack/echo.git synced 2025-01-12 01:22:21 +02:00
Code Issues Releases Activity

Add start time to request logger middleware values (#1991)

Browse Source
This commit is contained in:
Martti T 2021-09-23 23:17:09 +03:00 committed by GitHub
parent 4651c7aafe
commit a2e6ca7ed6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
middleware/request_logger.go
View File

@ -124,6 +124,8 @@ type RequestLoggerConfig struct {
// RequestLoggerValues contains extracted values from logger. // RequestLoggerValues contains extracted values from logger.
type RequestLoggerValues struct { type RequestLoggerValues struct {
// StartTime is time recorded before next middleware/handler is executed.
StartTime time.Time
// Latency is duration it took to execute rest of the handler chain (next(c) call). // Latency is duration it took to execute rest of the handler chain (next(c) call).
Latency time.Duration Latency time.Duration
// Protocol is request protocol (i.e. `HTTP/1.1` or `HTTP/2`) // Protocol is request protocol (i.e. `HTTP/1.1` or `HTTP/2`)
@ -215,7 +217,9 @@ func (config RequestLoggerConfig) ToMiddleware() (echo.MiddlewareFunc, error) {
} }
err := next(c) err := next(c)
v := RequestLoggerValues{} v := RequestLoggerValues{
StartTime: start,
}
if config.LogLatency { if config.LogLatency {
v.Latency = now().Sub(start) v.Latency = now().Sub(start)
} }

1
middleware/request_logger_test.go
View File

@ -296,6 +296,7 @@ func TestRequestLogger_allFields(t *testing.T) {
err := mw(c) err := mw(c)
assert.NoError(t, err) assert.NoError(t, err)
assert.Equal(t, time.Unix(1631045377, 0), expect.StartTime)
assert.Equal(t, 10*time.Second, expect.Latency) assert.Equal(t, 10*time.Second, expect.Latency)
assert.Equal(t, "HTTP/1.1", expect.Protocol) assert.Equal(t, "HTTP/1.1", expect.Protocol)
assert.Equal(t, "8.8.8.8", expect.RemoteIP) assert.Equal(t, "8.8.8.8", expect.RemoteIP)