go/echo
1
0
Fork 0
mirror of https://github.com/labstack/echo.git synced 2025-11-25 22:32:23 +02:00
Code Issues Releases Activity

Do not handle special trailing slash case for partial prefix (#1741)

Browse Source 
* Add tests for issue #1739
* Handle special trailing slash case only for a matching prefix

Only handle the special trailing slash case if the whole prefix matches to avoid matching   
a wrong route for overlapping prefixes, e.g. /users/* for the path /users_prefix/ where
the route is only a partial prefix of the requested path.
This commit is contained in:
stffabi
2021-01-03 19:35:00 +01:00
committed by GitHub
parent c7c792d3bd
commit a9df83037d
2 changed files with 45 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
router.go
View File

@@ -372,14 +372,14 @@ func (r *Router) Find(method, path string, c Context) {
if search == "" && (nn == nil || cn.parent == nil || cn.ppath != "") {
break
}
// Handle special case of trailing slash route with existing any route (see #1526)
if search == "" && path[len(path)-1] == '/' && cn.anyChildren != nil {
goto Any
}
}
// Attempt to go back up the tree on no matching prefix or no remaining search
if l != pl || search == "" {
// Handle special case of trailing slash route with existing any route (see #1526)
if path[len(path)-1] == '/' && cn.anyChildren != nil {
goto Any
}
if nn == nil { // Issue #1348
return // Not found
}