mirror of
https://github.com/labstack/echo.git
synced 2025-05-31 23:19:42 +02:00
Add support for configurable target header for the request_id middleware
This commit is contained in:
parent
b437ee3879
commit
c32fafad68
1
echo.go
1
echo.go
@ -214,6 +214,7 @@ const (
|
|||||||
HeaderXHTTPMethodOverride = "X-HTTP-Method-Override"
|
HeaderXHTTPMethodOverride = "X-HTTP-Method-Override"
|
||||||
HeaderXRealIP = "X-Real-IP"
|
HeaderXRealIP = "X-Real-IP"
|
||||||
HeaderXRequestID = "X-Request-ID"
|
HeaderXRequestID = "X-Request-ID"
|
||||||
|
HeaderXCorrelationID = "X-Correlation-ID"
|
||||||
HeaderXRequestedWith = "X-Requested-With"
|
HeaderXRequestedWith = "X-Requested-With"
|
||||||
HeaderServer = "Server"
|
HeaderServer = "Server"
|
||||||
HeaderOrigin = "Origin"
|
HeaderOrigin = "Origin"
|
||||||
|
@ -17,14 +17,18 @@ type (
|
|||||||
|
|
||||||
// RequestIDHandler defines a function which is executed for a request id.
|
// RequestIDHandler defines a function which is executed for a request id.
|
||||||
RequestIDHandler func(echo.Context, string)
|
RequestIDHandler func(echo.Context, string)
|
||||||
|
|
||||||
|
// TargetHeader defines what header to look for to populate the id
|
||||||
|
TargetHeader string
|
||||||
}
|
}
|
||||||
)
|
)
|
||||||
|
|
||||||
var (
|
var (
|
||||||
// DefaultRequestIDConfig is the default RequestID middleware config.
|
// DefaultRequestIDConfig is the default RequestID middleware config.
|
||||||
DefaultRequestIDConfig = RequestIDConfig{
|
DefaultRequestIDConfig = RequestIDConfig{
|
||||||
Skipper: DefaultSkipper,
|
Skipper: DefaultSkipper,
|
||||||
Generator: generator,
|
Generator: generator,
|
||||||
|
TargetHeader: echo.HeaderXRequestID,
|
||||||
}
|
}
|
||||||
)
|
)
|
||||||
|
|
||||||
@ -42,6 +46,9 @@ func RequestIDWithConfig(config RequestIDConfig) echo.MiddlewareFunc {
|
|||||||
if config.Generator == nil {
|
if config.Generator == nil {
|
||||||
config.Generator = generator
|
config.Generator = generator
|
||||||
}
|
}
|
||||||
|
if config.TargetHeader == "" {
|
||||||
|
config.TargetHeader = echo.HeaderXRequestID
|
||||||
|
}
|
||||||
|
|
||||||
return func(next echo.HandlerFunc) echo.HandlerFunc {
|
return func(next echo.HandlerFunc) echo.HandlerFunc {
|
||||||
return func(c echo.Context) error {
|
return func(c echo.Context) error {
|
||||||
@ -51,11 +58,11 @@ func RequestIDWithConfig(config RequestIDConfig) echo.MiddlewareFunc {
|
|||||||
|
|
||||||
req := c.Request()
|
req := c.Request()
|
||||||
res := c.Response()
|
res := c.Response()
|
||||||
rid := req.Header.Get(echo.HeaderXRequestID)
|
rid := req.Header.Get(config.TargetHeader)
|
||||||
if rid == "" {
|
if rid == "" {
|
||||||
rid = config.Generator()
|
rid = config.Generator()
|
||||||
}
|
}
|
||||||
res.Header().Set(echo.HeaderXRequestID, rid)
|
res.Header().Set(config.TargetHeader, rid)
|
||||||
if config.RequestIDHandler != nil {
|
if config.RequestIDHandler != nil {
|
||||||
config.RequestIDHandler(c, rid)
|
config.RequestIDHandler(c, rid)
|
||||||
}
|
}
|
||||||
|
@ -55,3 +55,34 @@ func TestRequestID_IDNotAltered(t *testing.T) {
|
|||||||
_ = h(c)
|
_ = h(c)
|
||||||
assert.Equal(t, rec.Header().Get(echo.HeaderXRequestID), "<sample-request-id>")
|
assert.Equal(t, rec.Header().Get(echo.HeaderXRequestID), "<sample-request-id>")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestRequestIDConfigDifferentHeader(t *testing.T) {
|
||||||
|
e := echo.New()
|
||||||
|
req := httptest.NewRequest(http.MethodGet, "/", nil)
|
||||||
|
rec := httptest.NewRecorder()
|
||||||
|
c := e.NewContext(req, rec)
|
||||||
|
handler := func(c echo.Context) error {
|
||||||
|
return c.String(http.StatusOK, "test")
|
||||||
|
}
|
||||||
|
|
||||||
|
rid := RequestIDWithConfig(RequestIDConfig{TargetHeader: echo.HeaderXCorrelationID})
|
||||||
|
h := rid(handler)
|
||||||
|
h(c)
|
||||||
|
assert.Len(t, rec.Header().Get(echo.HeaderXCorrelationID), 32)
|
||||||
|
|
||||||
|
// Custom generator and handler
|
||||||
|
customID := "customGenerator"
|
||||||
|
calledHandler := false
|
||||||
|
rid = RequestIDWithConfig(RequestIDConfig{
|
||||||
|
Generator: func() string { return customID },
|
||||||
|
TargetHeader: echo.HeaderXCorrelationID,
|
||||||
|
RequestIDHandler: func(_ echo.Context, id string) {
|
||||||
|
calledHandler = true
|
||||||
|
assert.Equal(t, customID, id)
|
||||||
|
},
|
||||||
|
})
|
||||||
|
h = rid(handler)
|
||||||
|
h(c)
|
||||||
|
assert.Equal(t, rec.Header().Get(echo.HeaderXCorrelationID), "customGenerator")
|
||||||
|
assert.True(t, calledHandler)
|
||||||
|
}
|
||||||
|
Loading…
x
Reference in New Issue
Block a user