Before this fix, Router#Find panics or enters in an infinite loop when
the context params values were set to a number less than the max number
of params supported by the Router.
This change allows middleware to replace the logger on the echo.Context
with a customized per-request logger with additional fields. The logger
is reset to default on every Reset() call.
Otherwise, the `http.ResponseWriter` passed to `next()` within the
middleware is unused. This precludes middlewares from wrapping the
http.ResponseWriter to do things like record the status code.
* echo.context.cjson should encode the JSON before writing the status code #1334 :
`response.Write` automatically sets status to `200` if a response code wasn't committed yet. This is convenient, but it ignores the fact that `response.Status` is a public field that may be set separately/before `response.Write` has been called
A `response.Status` is by default `0`, or `200` if the response was reset, so `response.Write` should fallback to `200` only if a code wasn't set yet.
* echo.context.cjson should encode the JSON before writing the status code #1334 :
Writing the response code before encoding the payload is prone to error.
If JSON encoding fails, the response code is already committed, the server is able to only modify the response body to reflect the error and the user receives an awkward response where the status is successful but the body reports an error.
Instead - set the desired code on `c.response.Status`. If writing eventually takes place, the desired code is committed. If an error occurs, the server can still change the response.
context.Attachment and context.Inline use context.contentDisposition under the hood.
However, context.contentDisposition does not forward the error of context.File, leading to response 200 OK even when the file does not exist.
This commit forward the return value of context.File to context.contentDisposition to prevent that.
This is especialy usefull when you use e.Static("/", "static") and you
want a notfoundhandler that serves your index.html like this:
echo.NotFoundHandler = func(c2 echo.Context) error {
index := filepath.Join(c.config.StaticDir, c.config.Index)
_, err := os.Open(index)
if err != nil {
return echo.ErrNotFound
}
return c2.File(path.Join(c.config.StaticDir, c.config.Index))
}
Another usecase with the Handler above is HTML5 SPF applications.
One caveat, you need to make sure that your NotFoundHandler doesn't
produce loops.
Signed-off-by: Rene Jochum <rene@jochums.at>
* Automatically use JSONPretty/XMLPretty if '?pretty' in querystring
* Update unit test cases
* Simplify code according comments
* Update guide for pretty json/xml
* Since some templating engines final result is a buffer, we've been casting them to strings, which is a bit unnecessary considering under the hood Echo supports this.
* Since some templating engines final result is a buffer, we've been casting them to strings, which is a bit unnecessary considering under the hood Echo supports this.
* Update context.go
* Update context_test.go
* Update context_test.go
* Utilize same design pattern for HTMLBlob as JSONBlob
* Streamlined a few more methods
* more consistent
Signed-off-by: Vishal Rana <vr@labstack.com>
