mirror of
https://github.com/labstack/echo.git
synced 2024-12-22 20:06:21 +02:00
6ef5f77bf2
WIP: make default logger implemented custom writer for jsonlike logs WIP: improve examples WIP: defaultErrorHandler use errors.As to unwrap errors. Update readme WIP: default logger logs json, restore e.Start method WIP: clean router.Match a bit WIP: func types/fields have echo.Context has first element WIP: remove yaml tags as functions etc can not be serialized anyway WIP: change BindPathParams,BindQueryParams,BindHeaders from methods to functions and reverse arguments to be like DefaultBinder.Bind is WIP: improved comments, logger now extracts status from error WIP: go mod tidy WIP: rebase with 4.5.0 WIP: * removed todos. * removed StartAutoTLS and StartH2CServer methods from `StartConfig` * KeyAuth middleware errorhandler can swallow the error and resume next middleware WIP: add RouterConfig.UseEscapedPathForMatching to use escaped path for matching request against routes WIP: FIXMEs WIP: upgrade golang-jwt/jwt to `v4` WIP: refactor http methods to return RouteInfo WIP: refactor static not creating multiple routes WIP: refactor route and middleware adding functions not to return error directly WIP: Use 401 for problematic/missing headers for key auth and JWT middleware (#1552, #1402). > In summary, a 401 Unauthorized response should be used for missing or bad authentication WIP: replace `HTTPError.SetInternal` with `HTTPError.WithInternal` so we could not mutate global error variables WIP: add RouteInfo and RouteMatchType into Context what we could know from in middleware what route was matched and/or type of that match (200/404/405) WIP: make notFoundHandler and methodNotAllowedHandler private. encourage that all errors be handled in Echo.HTTPErrorHandler WIP: server cleanup ideas WIP: routable.ForGroup WIP: note about logger middleware WIP: bind should not default values on second try. use crypto rand for better randomness WIP: router add route as interface and returns info as interface WIP: improve flaky test (remains still flaky) WIP: add notes about bind default values WIP: every route can have their own path params names WIP: routerCreator and different tests WIP: different things WIP: remove route implementation WIP: support custom method types WIP: extractor tests WIP: v5.0.x proposal over v4.4.0
53 lines
1.5 KiB
Go
53 lines
1.5 KiB
Go
package echo
|
|
|
|
import (
|
|
"errors"
|
|
"github.com/stretchr/testify/assert"
|
|
"net/http"
|
|
"testing"
|
|
)
|
|
|
|
func TestHTTPError(t *testing.T) {
|
|
t.Run("non-internal", func(t *testing.T) {
|
|
err := NewHTTPError(http.StatusBadRequest, map[string]interface{}{
|
|
"code": 12,
|
|
})
|
|
|
|
assert.Equal(t, "code=400, message=map[code:12]", err.Error())
|
|
})
|
|
t.Run("internal", func(t *testing.T) {
|
|
err := NewHTTPError(http.StatusBadRequest, map[string]interface{}{
|
|
"code": 12,
|
|
})
|
|
err = err.WithInternal(errors.New("internal error"))
|
|
assert.Equal(t, "code=400, message=map[code:12], internal=internal error", err.Error())
|
|
})
|
|
}
|
|
|
|
func TestNewHTTPErrorWithInternal(t *testing.T) {
|
|
he := NewHTTPErrorWithInternal(http.StatusBadRequest, errors.New("test"), "test message")
|
|
assert.Equal(t, "code=400, message=test message, internal=test", he.Error())
|
|
}
|
|
|
|
func TestNewHTTPErrorWithInternal_noCustomMessage(t *testing.T) {
|
|
he := NewHTTPErrorWithInternal(http.StatusBadRequest, errors.New("test"))
|
|
assert.Equal(t, "code=400, message=Bad Request, internal=test", he.Error())
|
|
}
|
|
|
|
func TestHTTPError_Unwrap(t *testing.T) {
|
|
t.Run("non-internal", func(t *testing.T) {
|
|
err := NewHTTPError(http.StatusBadRequest, map[string]interface{}{
|
|
"code": 12,
|
|
})
|
|
|
|
assert.Nil(t, errors.Unwrap(err))
|
|
})
|
|
t.Run("internal", func(t *testing.T) {
|
|
err := NewHTTPError(http.StatusBadRequest, map[string]interface{}{
|
|
"code": 12,
|
|
})
|
|
err = err.WithInternal(errors.New("internal error"))
|
|
assert.Equal(t, "internal error", errors.Unwrap(err).Error())
|
|
})
|
|
}
|