mirror of
https://github.com/labstack/echo.git
synced 2025-01-07 23:01:56 +02:00
6ef5f77bf2
WIP: make default logger implemented custom writer for jsonlike logs WIP: improve examples WIP: defaultErrorHandler use errors.As to unwrap errors. Update readme WIP: default logger logs json, restore e.Start method WIP: clean router.Match a bit WIP: func types/fields have echo.Context has first element WIP: remove yaml tags as functions etc can not be serialized anyway WIP: change BindPathParams,BindQueryParams,BindHeaders from methods to functions and reverse arguments to be like DefaultBinder.Bind is WIP: improved comments, logger now extracts status from error WIP: go mod tidy WIP: rebase with 4.5.0 WIP: * removed todos. * removed StartAutoTLS and StartH2CServer methods from `StartConfig` * KeyAuth middleware errorhandler can swallow the error and resume next middleware WIP: add RouterConfig.UseEscapedPathForMatching to use escaped path for matching request against routes WIP: FIXMEs WIP: upgrade golang-jwt/jwt to `v4` WIP: refactor http methods to return RouteInfo WIP: refactor static not creating multiple routes WIP: refactor route and middleware adding functions not to return error directly WIP: Use 401 for problematic/missing headers for key auth and JWT middleware (#1552, #1402). > In summary, a 401 Unauthorized response should be used for missing or bad authentication WIP: replace `HTTPError.SetInternal` with `HTTPError.WithInternal` so we could not mutate global error variables WIP: add RouteInfo and RouteMatchType into Context what we could know from in middleware what route was matched and/or type of that match (200/404/405) WIP: make notFoundHandler and methodNotAllowedHandler private. encourage that all errors be handled in Echo.HTTPErrorHandler WIP: server cleanup ideas WIP: routable.ForGroup WIP: note about logger middleware WIP: bind should not default values on second try. use crypto rand for better randomness WIP: router add route as interface and returns info as interface WIP: improve flaky test (remains still flaky) WIP: add notes about bind default values WIP: every route can have their own path params names WIP: routerCreator and different tests WIP: different things WIP: remove route implementation WIP: support custom method types WIP: extractor tests WIP: v5.0.x proposal over v4.4.0
116 lines
2.6 KiB
Go
116 lines
2.6 KiB
Go
package middleware
|
|
|
|
import (
|
|
"errors"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/labstack/echo/v4"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestBodyDump(t *testing.T) {
|
|
e := echo.New()
|
|
hw := "Hello, World!"
|
|
req := httptest.NewRequest(http.MethodPost, "/", strings.NewReader(hw))
|
|
rec := httptest.NewRecorder()
|
|
c := e.NewContext(req, rec)
|
|
h := func(c echo.Context) error {
|
|
body, err := ioutil.ReadAll(c.Request().Body)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return c.String(http.StatusOK, string(body))
|
|
}
|
|
|
|
requestBody := ""
|
|
responseBody := ""
|
|
mw, err := BodyDumpConfig{Handler: func(c echo.Context, reqBody, resBody []byte) {
|
|
requestBody = string(reqBody)
|
|
responseBody = string(resBody)
|
|
}}.ToMiddleware()
|
|
assert.NoError(t, err)
|
|
|
|
if assert.NoError(t, mw(h)(c)) {
|
|
assert.Equal(t, requestBody, hw)
|
|
assert.Equal(t, responseBody, hw)
|
|
assert.Equal(t, http.StatusOK, rec.Code)
|
|
assert.Equal(t, hw, rec.Body.String())
|
|
}
|
|
|
|
}
|
|
|
|
func TestBodyDump_skipper(t *testing.T) {
|
|
e := echo.New()
|
|
|
|
isCalled := false
|
|
mw, err := BodyDumpConfig{
|
|
Skipper: func(c echo.Context) bool {
|
|
return true
|
|
},
|
|
Handler: func(c echo.Context, reqBody, resBody []byte) {
|
|
isCalled = true
|
|
},
|
|
}.ToMiddleware()
|
|
assert.NoError(t, err)
|
|
|
|
req := httptest.NewRequest(http.MethodPost, "/", strings.NewReader("{}"))
|
|
rec := httptest.NewRecorder()
|
|
c := e.NewContext(req, rec)
|
|
h := func(c echo.Context) error {
|
|
return errors.New("some error")
|
|
}
|
|
|
|
err = mw(h)(c)
|
|
assert.EqualError(t, err, "some error")
|
|
assert.False(t, isCalled)
|
|
}
|
|
|
|
func TestBodyDump_fails(t *testing.T) {
|
|
e := echo.New()
|
|
hw := "Hello, World!"
|
|
req := httptest.NewRequest(http.MethodPost, "/", strings.NewReader(hw))
|
|
rec := httptest.NewRecorder()
|
|
c := e.NewContext(req, rec)
|
|
h := func(c echo.Context) error {
|
|
return errors.New("some error")
|
|
}
|
|
|
|
mw, err := BodyDumpConfig{Handler: func(c echo.Context, reqBody, resBody []byte) {}}.ToMiddleware()
|
|
assert.NoError(t, err)
|
|
|
|
err = mw(h)(c)
|
|
assert.EqualError(t, err, "some error")
|
|
assert.Equal(t, http.StatusOK, rec.Code)
|
|
|
|
}
|
|
|
|
func TestBodyDumpWithConfig_panic(t *testing.T) {
|
|
assert.Panics(t, func() {
|
|
mw := BodyDumpWithConfig(BodyDumpConfig{
|
|
Skipper: nil,
|
|
Handler: nil,
|
|
})
|
|
assert.NotNil(t, mw)
|
|
})
|
|
|
|
assert.NotPanics(t, func() {
|
|
mw := BodyDumpWithConfig(BodyDumpConfig{Handler: func(c echo.Context, reqBody, resBody []byte) {}})
|
|
assert.NotNil(t, mw)
|
|
})
|
|
}
|
|
|
|
func TestBodyDump_panic(t *testing.T) {
|
|
assert.Panics(t, func() {
|
|
mw := BodyDump(nil)
|
|
assert.NotNil(t, mw)
|
|
})
|
|
|
|
assert.NotPanics(t, func() {
|
|
BodyDump(func(c echo.Context, reqBody, resBody []byte) {})
|
|
})
|
|
}
|