mirror of
https://github.com/labstack/echo.git
synced 2024-11-24 08:22:21 +02:00
ef82f3e034
In HTTPSRedirect and similar middlewares, determining if redirection is needed using `c.IsTLS()` causes redirect loop when an application is running behind a TLS termination proxy, e.g. AWS ELB. Instead, I believe, redirection should be determined by `c.Scheme() != "https"`. This works well even behind a TLS termination proxy.
90 lines
2.6 KiB
Go
90 lines
2.6 KiB
Go
package middleware
|
|
|
|
import (
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
|
|
"github.com/labstack/echo"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
type middlewareGenerator func() echo.MiddlewareFunc
|
|
|
|
func TestRedirectHTTPSRedirect(t *testing.T) {
|
|
res := redirectTest(HTTPSRedirect, "labstack.com", nil)
|
|
|
|
assert.Equal(t, http.StatusMovedPermanently, res.Code)
|
|
assert.Equal(t, "https://labstack.com/", res.Header().Get(echo.HeaderLocation))
|
|
}
|
|
|
|
func TestHTTPSRedirectBehindTLSTerminationProxy(t *testing.T) {
|
|
header := http.Header{}
|
|
header.Set(echo.HeaderXForwardedProto, "https")
|
|
res := redirectTest(HTTPSRedirect, "labstack.com", header)
|
|
|
|
assert.Equal(t, http.StatusOK, res.Code)
|
|
}
|
|
|
|
func TestRedirectHTTPSWWWRedirect(t *testing.T) {
|
|
res := redirectTest(HTTPSWWWRedirect, "labstack.com", nil)
|
|
|
|
assert.Equal(t, http.StatusMovedPermanently, res.Code)
|
|
assert.Equal(t, "https://www.labstack.com/", res.Header().Get(echo.HeaderLocation))
|
|
}
|
|
|
|
func TestRedirectHTTPSWWWRedirectBehindTLSTerminationProxy(t *testing.T) {
|
|
header := http.Header{}
|
|
header.Set(echo.HeaderXForwardedProto, "https")
|
|
res := redirectTest(HTTPSWWWRedirect, "labstack.com", header)
|
|
|
|
assert.Equal(t, http.StatusOK, res.Code)
|
|
}
|
|
|
|
func TestRedirectHTTPSNonWWWRedirect(t *testing.T) {
|
|
res := redirectTest(HTTPSNonWWWRedirect, "www.labstack.com", nil)
|
|
|
|
assert.Equal(t, http.StatusMovedPermanently, res.Code)
|
|
assert.Equal(t, "https://labstack.com/", res.Header().Get(echo.HeaderLocation))
|
|
}
|
|
|
|
func TestRedirectHTTPSNonWWWRedirectBehindTLSTerminationProxy(t *testing.T) {
|
|
header := http.Header{}
|
|
header.Set(echo.HeaderXForwardedProto, "https")
|
|
res := redirectTest(HTTPSNonWWWRedirect, "www.labstack.com", header)
|
|
|
|
assert.Equal(t, http.StatusOK, res.Code)
|
|
}
|
|
|
|
func TestRedirectWWWRedirect(t *testing.T) {
|
|
res := redirectTest(WWWRedirect, "labstack.com", nil)
|
|
|
|
assert.Equal(t, http.StatusMovedPermanently, res.Code)
|
|
assert.Equal(t, "http://www.labstack.com/", res.Header().Get(echo.HeaderLocation))
|
|
}
|
|
|
|
func TestRedirectNonWWWRedirect(t *testing.T) {
|
|
res := redirectTest(NonWWWRedirect, "www.labstack.com", nil)
|
|
|
|
assert.Equal(t, http.StatusMovedPermanently, res.Code)
|
|
assert.Equal(t, "http://labstack.com/", res.Header().Get(echo.HeaderLocation))
|
|
}
|
|
|
|
func redirectTest(fn middlewareGenerator, host string, header http.Header) *httptest.ResponseRecorder {
|
|
e := echo.New()
|
|
next := func(c echo.Context) (err error) {
|
|
return c.NoContent(http.StatusOK)
|
|
}
|
|
req := httptest.NewRequest(echo.GET, "/", nil)
|
|
req.Host = host
|
|
if header != nil {
|
|
req.Header = header
|
|
}
|
|
res := httptest.NewRecorder()
|
|
c := e.NewContext(req, res)
|
|
|
|
fn()(next)(c)
|
|
|
|
return res
|
|
}
|