go/ferret
1
0
Fork 0
mirror of https://github.com/MontFerret/ferret.git synced 2025-11-06 08:39:09 +02:00
Code Issues Releases Activity

Added a check whether an element is in the viewport before scrolling (#342)

Browse Source
This commit is contained in:
Tim Voronov
2019-07-26 15:34:18 -04:00
committed by GitHub
parent b323a984cc
commit 843bc2a44e
1 changed files with 29 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
pkg/drivers/cdp/templates/scroll.go
View File

@@ -6,6 +6,19 @@ import (
)
const (
isElementInViewportTemplate = `
function isInViewport(elem) {
var bounding = elem.getBoundingClientRect();
return (
bounding.top >= 0 &&
bounding.left >= 0 &&
bounding.bottom <= (window.innerHeight || document.documentElement.clientHeight) &&
bounding.right <= (window.innerWidth || document.documentElement.clientWidth)
);
};
`
scrollTopTemplate = `
window.scrollTo({
left: 0,
@@ -24,9 +37,14 @@ const (
scrollIntoViewTemplate = `
(el) => {
el.scrollIntoView({
behavior: 'instant'
});
` + isElementInViewportTemplate + `
if (!isInViewport(el)) {
el.scrollIntoView({
behavior: 'instant'
});
}
return true;
}
@@ -59,10 +77,14 @@ func ScrollIntoViewBySelector(selector string) string {
throw new Error('%s');
}
el.scrollIntoView({
behavior: 'instant'
});
%s
if (!isInViewport(el)) {
el.scrollIntoView({
behavior: 'instant'
});
}
return true;
`, selector, drivers.ErrNotFound)
`, selector, drivers.ErrNotFound, isElementInViewportTemplate)
}