go/ferret
1
0
Fork 0
mirror of https://github.com/MontFerret/ferret.git synced 2025-07-05 00:49:00 +02:00
Code Issues Releases Activity

Feature/new selector type (#657)

Browse Source 
* Added remote type reference resolver

* Added support of XPath query selector

* Added CDP e2e testss covering XPath integration

* Added additional CDP e2e tests covering XPath integration

* Added type check to QuerySelector casting function

* Fixed XPath e2e tests

* Fixed vuln issue

* Added support of XPath selectors to http driver

* Added e2e tests for XPAth
This commit is contained in:
Tim Voronov
2021-09-16 21:40:20 -04:00
committed by GitHub
parent a000302259
commit 90427cd537
167 changed files with 2275 additions and 1102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
pkg/stdlib/html/wait_element.go
View File

@ -40,7 +40,12 @@ func waitElementWhen(ctx context.Context, args []core.Value, when drivers.WaitEv
return values.None, err
}
selector := args[1].String()
selector, err := drivers.ToQuerySelector(args[1])
if err != nil {
return values.None, err
}
timeout := values.NewInt(drivers.DefaultWaitTimeout)
if len(args) > 2 {
@ -56,5 +61,5 @@ func waitElementWhen(ctx context.Context, args []core.Value, when drivers.WaitEv
ctx, fn := waitTimeout(ctx, timeout)
defer fn()
return values.True, el.WaitForElement(ctx, values.NewString(selector), when)
return values.True, el.WaitForElement(ctx, selector, when)
}