go/ferret
1
0
Fork 0
mirror of https://github.com/MontFerret/ferret.git synced 2025-08-13 19:52:52 +02:00
Code Issues Releases Activity

Linter Cleanups (#294)

Browse Source 
* sync with MontFerret/ferret

* fix --param handling

When params is converted to map it uses strings.Split,
which slices a string into all substrings separated by :.

* remove impossible conditions nil != nil

* delete ineffectual assignments

* replace '+= 1' with '++'

* remove useless comparison with nil

* merge variable declarations

* remove bool comparison

* fix imports

* fix imports

* delete unused file

* use copy instead of loop

* delete unused DummyInterface

* remove unnecassary break statements

* tidy modules
This commit is contained in:
3timeslazy
2019-05-04 00:10:34 +03:00
committed by Tim Voronov
parent 69816e8b54
commit acf2f13dcb
50 changed files with 105 additions and 355 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/runtime/expressions/operators/array.go
View File

@@ -60,7 +60,7 @@ func NewArrayOperator(
return nil, core.Error(core.ErrMissedArgument, "right expression")
}
if IsValidArrayOperatorType(aotype) == false {
if !IsValidArrayOperatorType(aotype) {
return nil, core.Error(core.ErrInvalidArgument, "operator")
}

4
pkg/runtime/expressions/operators/in.go
View File

@@ -58,8 +58,8 @@ func (operator *InOperator) Eval(_ context.Context, left, right core.Value) (cor
found := arr.IndexOf(left) > -1
if operator.not {
return values.NewBoolean(found == false), nil
return values.NewBoolean(!found), nil
}
return values.NewBoolean(found == true), nil
return values.NewBoolean(found), nil
}