go/ferret
1
0
Fork 0
mirror of https://github.com/MontFerret/ferret.git synced 2025-07-03 00:46:51 +02:00
Code Issues Releases Activity

Feature/#220 iframe support (#315)

Browse Source 
* Refactored Virtual DOM structure
* Added new E2E tests
* Updated E2E Test Runner
This commit is contained in:
Tim Voronov
2019-06-19 17:58:56 -04:00
committed by GitHub
parent 8c07516ed1
commit d7b923e4c3
103 changed files with 2815 additions and 1629 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/stdlib/html/scroll_element.go
View File

@ -20,7 +20,7 @@ func ScrollInto(ctx context.Context, args ...core.Value) (core.Value, error) {
}
if len(args) == 2 {
err = core.ValidateType(args[0], drivers.HTMLDocumentType)
doc, err := drivers.ToDocument(args[0])
if err != nil {
return values.None, err
@ -32,8 +32,6 @@ func ScrollInto(ctx context.Context, args ...core.Value) (core.Value, error) {
return values.None, err
}
// Document with a selector
doc := args[0].(drivers.HTMLDocument)
selector := args[1].(values.String)
return values.None, doc.ScrollBySelector(ctx, selector)
@ -45,8 +43,12 @@ func ScrollInto(ctx context.Context, args ...core.Value) (core.Value, error) {
return values.None, err
}
// Element
el := args[0].(drivers.HTMLElement)
// GetElement
el, err := drivers.ToElement(args[0])
if err != nil {
return values.None, err
}
return values.None, el.ScrollIntoView(ctx)
}