From d7df80df9d3f995769da525be3e57448fb26ce61 Mon Sep 17 00:00:00 2001 From: Tim Voronov Date: Mon, 15 Oct 2018 21:56:07 -0400 Subject: [PATCH] Removed unneccessary goroutine --- examples/navigate.fql | 4 +--- pkg/html/dynamic/events/broker.go | 19 +++++++++---------- 2 files changed, 10 insertions(+), 13 deletions(-) diff --git a/examples/navigate.fql b/examples/navigate.fql index 7d1d48aa..c81769f5 100644 --- a/examples/navigate.fql +++ b/examples/navigate.fql @@ -7,6 +7,4 @@ NAVIGATE(doc, "https://github.com/features") LET features = ELEMENT(doc, '.application-main') LET featuresTxt = features.innerText -LOG("featuresTxt:", featuresTxt) - -RETURN mainTxt == featuresTxt +RETURN mainTxt != featuresTxt diff --git a/pkg/html/dynamic/events/broker.go b/pkg/html/dynamic/events/broker.go index 93e69ac1..da814c1d 100644 --- a/pkg/html/dynamic/events/broker.go +++ b/pkg/html/dynamic/events/broker.go @@ -258,7 +258,6 @@ func (broker *EventBroker) emit(ctx context.Context, event Event, message interf } broker.mu.Lock() - defer broker.mu.Unlock() listeners, ok := broker.listeners[event] @@ -269,14 +268,14 @@ func (broker *EventBroker) emit(ctx context.Context, event Event, message interf snapshot := make([]EventListener, len(listeners)) copy(snapshot, listeners) - go func() { - for _, listener := range snapshot { - select { - case <-ctx.Done(): - return - default: - listener(message) - } + broker.mu.Unlock() + + for _, listener := range snapshot { + select { + case <-ctx.Done(): + return + default: + listener(message) } - }() + } }