go/go-clickhouse
1
0
Fork 0
mirror of https://github.com/uptrace/go-clickhouse.git synced 2025-06-29 00:21:46 +02:00
Code Issues Releases Activity

fix: change rollback to always record migrations

Browse Source
This commit is contained in:
Vladimir Mihailenco
2022-03-25 15:50:00 +02:00
parent dca5db22ff
commit d6e6e55142
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
chmigrate/migrator.go
View File

@ -186,15 +186,16 @@ func (m *Migrator) Rollback(ctx context.Context, opts ...MigrationOption) (*Migr
for i := len(lastGroup.Migrations) - 1; i >= 0; i-- { for i := len(lastGroup.Migrations) - 1; i >= 0; i-- {
migration := &lastGroup.Migrations[i] migration := &lastGroup.Migrations[i]
// Always mark migration as unapplied to match migrate behavior.
if err := m.MarkUnapplied(ctx, migration); err != nil {
return nil, err
}
if !cfg.nop && migration.Down != nil { if !cfg.nop && migration.Down != nil {
if err := migration.Down(ctx, m.db); err != nil { if err := migration.Down(ctx, m.db); err != nil {
return nil, err return nil, err
} }
} }
if err := m.MarkUnapplied(ctx, migration); err != nil {
return nil, err
}
} }
return lastGroup, nil return lastGroup, nil