go/go-jira
1
0
Fork 0
mirror of https://github.com/interviewstreet/go-jira.git synced 2025-06-29 00:21:53 +02:00
Code Issues Releases Activity

Makes Update call UpdateWithOptions with a blank options struct

Browse Source
This commit is contained in:
spmassot
2018-10-17 15:44:13 -04:00
parent 8ddf76d2c9
commit 0f70c8e581
1 changed files with 5 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
issue.go
View File

@ -29,8 +29,8 @@ type IssueService struct {
client *Client client *Client
} }
// UpdateOptions specifies the optional parameters to the Edit issue // UpdateQueryOptions specifies the optional parameters to the Edit issue
type UpdateOptions struct { type UpdateQueryOptions struct {
NotifyUsers bool `url:"notifyUsers,omitempty"` NotifyUsers bool `url:"notifyUsers,omitempty"`
OverrideScreenSecurity bool `url:"overrideScreenSecurity,omitempty"` OverrideScreenSecurity bool `url:"overrideScreenSecurity,omitempty"`
OverrideEditableFlag bool `url:"overrideEditableFlag,omitempty"` OverrideEditableFlag bool `url:"overrideEditableFlag,omitempty"`
@ -660,7 +660,7 @@ func (s *IssueService) Create(issue *Issue) (*Issue, *Response, error) {
// while also specifiying query params. The issue is found by key. // while also specifiying query params. The issue is found by key.
// //
// JIRA API docs: https://docs.atlassian.com/jira/REST/cloud/#api/2/issue-editIssue // JIRA API docs: https://docs.atlassian.com/jira/REST/cloud/#api/2/issue-editIssue
func (s *IssueService) UpdateWithOptions(issue *Issue, opts *UpdateOptions) (*Issue, *Response, error) { func (s *IssueService) UpdateWithOptions(issue *Issue, opts *UpdateQueryOptions) (*Issue, *Response, error) {
apiEndpoint := fmt.Sprintf("rest/api/3/issue/%v", issue.Key) apiEndpoint := fmt.Sprintf("rest/api/3/issue/%v", issue.Key)
url, err := addOptions(apiEndpoint, opts) url, err := addOptions(apiEndpoint, opts)
if err != nil { if err != nil {
@ -686,21 +686,8 @@ func (s *IssueService) UpdateWithOptions(issue *Issue, opts *UpdateOptions) (*Is
// //
// JIRA API docs: https://docs.atlassian.com/jira/REST/cloud/#api/2/issue-editIssue // JIRA API docs: https://docs.atlassian.com/jira/REST/cloud/#api/2/issue-editIssue
func (s *IssueService) Update(issue *Issue) (*Issue, *Response, error) { func (s *IssueService) Update(issue *Issue) (*Issue, *Response, error) {
apiEndpoint := fmt.Sprintf("rest/api/2/issue/%v", issue.Key) opts := &UpdateQueryOptions{}
req, err := s.client.NewRequest("PUT", apiEndpoint, issue) return s.UpdateWithOptions(issue, opts)
if err != nil {
return nil, nil, err
}
resp, err := s.client.Do(req, nil)
if err != nil {
jerr := NewJiraError(resp, err)
return nil, resp, jerr
}
// This is just to follow the rest of the API's convention of returning an issue.
// Returning the same pointer here is pointless, so we return a copy instead.
ret := *issue
return &ret, resp, nil
} }
// UpdateIssue updates an issue from a JSON representation. The issue is found by key. // UpdateIssue updates an issue from a JSON representation. The issue is found by key.