From 462a4cd5f80da6fe2d23c50d1c3a043d74bf4d58 Mon Sep 17 00:00:00 2001 From: Evgen Kostenko Date: Wed, 1 Jun 2016 21:24:21 +0300 Subject: [PATCH 1/3] delete uncompleted boards --- board.go | 1 - 1 file changed, 1 deletion(-) delete mode 100644 board.go diff --git a/board.go b/board.go deleted file mode 100644 index 8fa05fc..0000000 --- a/board.go +++ /dev/null @@ -1 +0,0 @@ -package jira From c9ac91a57cd3d9c54759ba4a41d575ea17f084f3 Mon Sep 17 00:00:00 2001 From: Evgen Kostenko Date: Wed, 1 Jun 2016 21:36:11 +0300 Subject: [PATCH 2/3] add one more test for project service --- project_test.go | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/project_test.go b/project_test.go index 22d2d86..04eb5b2 100644 --- a/project_test.go +++ b/project_test.go @@ -54,3 +54,27 @@ func TestProjectGet(t *testing.T) { t.Errorf("Error given: %s", err) } } + +func TestProjectWrongGet(t *testing.T) { + setup() + defer teardown() + testApiEdpoint := "/rest/api/2/project/99999999" + + testMux.HandleFunc(testApiEdpoint, func(w http.ResponseWriter, r *http.Request) { + testMethod(t, r, "GET") + testRequestURL(t, r, testApiEdpoint) + fmt.Fprint(w, nil) + }) + + projects, resp, err := testClient.Project.Get("12310505") + if projects != nil { + t.Errorf("Expected nil. Got %s", projects) + } + + if resp.Status == "404" { + t.Errorf("Expected status 404. Got %s", resp.Status) + } + if err == nil { + t.Errorf("Error given: %s", err) + } +} From c66958e3f28c0768f1f6833e2b6f53a455c8dfab Mon Sep 17 00:00:00 2001 From: Evgen Kostenko Date: Thu, 2 Jun 2016 15:59:40 +0300 Subject: [PATCH 3/3] refactor project tests + go fmt --- jira.go | 2 +- project_test.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/jira.go b/jira.go index 09a5f14..09c5498 100644 --- a/jira.go +++ b/jira.go @@ -3,10 +3,10 @@ package jira import ( "bytes" "encoding/json" + "fmt" "io" "net/http" "net/url" - "fmt" ) // A Client manages communication with the JIRA API. diff --git a/project_test.go b/project_test.go index 04eb5b2..e0ea0bd 100644 --- a/project_test.go +++ b/project_test.go @@ -55,7 +55,7 @@ func TestProjectGet(t *testing.T) { } } -func TestProjectWrongGet(t *testing.T) { +func TestProjectGet_NoProject(t *testing.T) { setup() defer teardown() testApiEdpoint := "/rest/api/2/project/99999999" @@ -66,7 +66,7 @@ func TestProjectWrongGet(t *testing.T) { fmt.Fprint(w, nil) }) - projects, resp, err := testClient.Project.Get("12310505") + projects, resp, err := testClient.Project.Get("99999999") if projects != nil { t.Errorf("Expected nil. Got %s", projects) }