go/go-jira
1
0
Fork 0
mirror of https://github.com/interviewstreet/go-jira.git synced 2025-12-23 23:51:10 +02:00
Code Issues Releases Activity

Applied a few smaller code changes, cleanups and removed DoNoClose, because a similar function was merged in between

Browse Source
This commit is contained in:
Andy Grunwald
2016-05-27 14:14:09 +02:00
parent b1d5d70b51
commit c92a43e43d
4 changed files with 13 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
issue.go
View File

@@ -34,7 +34,6 @@ type Attachment struct {
Self string `json:"self,omitempty"`
Id string `json:"id,omitempty"`
Filename string `json:"filename,omitempty"`
// TODO Missing fields
Author *Assignee `json:"author,omitempty"`
Created string `json:"created,omitempty"`
Size int `json:"size,omitempty"`
@@ -254,9 +253,10 @@ func (s *IssueService) Get(issueID string) (*Issue, *http.Response, error) {
return issue, resp, nil
}
// DownloadAttachment returns an ioReader of an attachment for a given attachment Id
// The attachment is in the Body of the response
// The caller should close resp.Body
// DownloadAttachment returns a http.Response of an attachment for a given attachmentID.
// The attachment is in the http.Response.Body of the response.
// This is an io.ReadCloser.
// The caller should close the resp.Body.
func (s *IssueService) DownloadAttachment(attachmentID string) (*http.Response, error) {
apiEndpoint := fmt.Sprintf("secure/attachment/%s/", attachmentID)
req, err := s.client.NewRequest("GET", apiEndpoint, nil)
@@ -264,7 +264,7 @@ func (s *IssueService) DownloadAttachment(attachmentID string) (*http.Response,
return nil, err
}
resp, err := s.client.DoNoClose(req, nil)
resp, err := s.client.Do(req, nil)
if err != nil {
return resp, err
}
@@ -272,7 +272,7 @@ func (s *IssueService) DownloadAttachment(attachmentID string) (*http.Response,
return resp, nil
}
// PostAttachment uploads an attachment provided as an io.Reader to a given attachment ID
// PostAttachment uploads r (io.Reader) as an attachment to a given attachmentID
func (s *IssueService) PostAttachment(attachmentID string, r io.Reader, attachmentName string) (*[]Attachment, *http.Response, error) {
apiEndpoint := fmt.Sprintf("rest/api/2/issue/%s/attachments", attachmentID)
@@ -307,7 +307,6 @@ func (s *IssueService) PostAttachment(attachmentID string, r io.Reader, attachme
}
return attachment, resp, nil
}
// Create creates an issue or a sub-task from a JSON representation.