go/go-jira
1
0
Fork 0
mirror of https://github.com/interviewstreet/go-jira.git synced 2025-04-04 22:04:28 +02:00
Code Issues Releases Activity

chore(test): Remove unit testing log output for success cases (#293)

Browse Source 
During running the unit tests we see output like

=== RUN   TestIssueService_DeleteAttachment
    TestIssueService_DeleteAttachment: issue_test.go:587: Attachment deleted
    TestIssueService_DeleteAttachment: issue_test.go:592: No error

This log can be removed, because this mostly confirms the success case.
The opposite case is throwing a testing error, which is visible as well.
Hence, there is no need to log this messages durcing testing
This commit is contained in:
Andy Grunwald 2020-05-03 15:45:24 +02:00 committed by GitHub
parent 80c02828ca
commit eaaeec5f1c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
issue_test.go
View File

@ -583,13 +583,10 @@ func TestIssueService_DeleteAttachment(t *testing.T) {
if resp.StatusCode == 404 { if resp.StatusCode == 404 {
t.Error("Attachment not found") t.Error("Attachment not found")
} }
} else {
t.Log("Attachment deleted")
} }
if err != nil { if err != nil {
t.Errorf("Error given: %s", err) t.Errorf("Error given: %s", err)
} else {
t.Log("No error")
} }
} }