go v1.14 was released, but we don't test for it right now.
Additionally, the allowed failure for go v1.13 is removed, because this library should support this version (and it is not marked as not supported).
Makes the Pull Request template a bit more explicit.
Goals of this are:
- to guide the user more
- to make it more clear what we are asking for (e.g. what kind of tests)
- to ask for code examples (that could be used for documentation)
- to start a thought process for the contributor
- to make the maintainers work a bit easier
Addiotionally we formatted the links in the checklist a bit more
readable for a human.
GitHub offers a .github meta folder to store things like
Pull Request or Issue templates.
We move this file into the meta folder to keep the root a bit cleaner
and only related to code and not to the VCS environment.
The Makefile contains now additional commands to support
during development and aim for a higher source code quality:
- go vet
- go fmt
- same unit tests run command like travis
- static analysis
- and a target to run all together
If millisecond in go time is empty
they will be not exist in result string
if using "999" in format. And jira api
will response with error in the case.
Using "000" fix the problem.
Add test for time marshaling.
When used with a load balanced Jira, the SearchPages method would end
up in an endless loop. This was caused by a bug where Jira would not
handle the MaxResults=50 that is sent by defaul properly, thus retur-
ning no issues. The SearchPages method didn't check for empty results
and ended up in an endless loop.
Fixed this by
1. Pre-escaping '&maxResults' to '&MaxResults'.
2. Adding a check in SearchPages to see if the issues array is empty
before going into the endless 'for'.
Also fixed the appropriate tests.
Fixes issue #260.
JIRA API is able to provide clients with list of transitions available
for issue in its current state (https://docs.atlassian.com/software/
jira/docs/api/REST/latest/#api/2/issue-getIssue)
Go-Jira client ignored the 'transitions' information in JIRA API JSON
response. Now it provides full access to transitions available for
current user in issue's current state
Setting up the NewClient method to accept an interface that gives access
to the Do method of the http.Client rather than using a hard http.Client
so that an interface can be passed for mocking and other non-standard
clients can be used with go-jira.
