mirror of
https://github.com/interviewstreet/go-jira.git
synced 2024-11-28 08:39:03 +02:00
43e8242f2c
* style: Fix staticcheck errors for "error strings should not be capitalized (ST1005)" staticcheck is a static analysis tool for go. It reports several "error strings should not be capitalized (ST1005)" messages. Here, we fix it to be more compliant with the go coding styleguide. Related: #280 * style: Fix staticcheck errors for "printf-style function with dynamic format ... (SA1006)" staticcheck is a static analysis tool for go. It reports several "printf-style function with dynamic format string and no further arguments should use print-style function instead (SA1006)" messages. Here, we fix it to be more compliant with the go coding styleguide. Related: #280 * style: Fix staticcheck errors for "type X is unused (U1000)" staticcheck is a static analysis tool for go. It reports several "type X is unused (U1000)" messages. Here, we fix it to be more compliant with the go coding styleguide. Related: #280 * style: Fix staticcheck errors for "should use X instead (S1003 & SA6005)" staticcheck is a static analysis tool for go. It reports several - should use !bytes.Contains(b, []byte(`"password":"bar"`)) instead (S1003) - should use strings.EqualFold instead (SA6005) messages. Here, we fix it to be more compliant with the go coding styleguide. Related: #280 * style: Fix staticcheck errors for "unnecessary use of fmt.Sprintf (S1039)" staticcheck is a static analysis tool for go. It report several "unnecessary use of fmt.Sprintf (S1039)" messages. Here, we fix it to be more compliant with the go coding styleguide. Related: #280 * style: Fix staticcheck errors for "this value of X is never used (SA4006)" staticcheck is a static analysis tool for go. It report several "this value of X is never used (SA4006)" messages. Here, we fix it to be more compliant with the go coding styleguide. Related: #280 * style: Fix staticcheck errors for "redundant return statement (S1023)" staticcheck is a static analysis tool for go. It report several "redundant return statement (S1023)" messages. Here, we fix it to be more compliant with the go coding styleguide. Related: #280 * style: Fix staticcheck errors for "possible nil pointer dereference (SA5011)" staticcheck is a static analysis tool for go. It report several file.go:Line:character: possible nil pointer dereference (SA5011) file.go:Line:character: this check suggests that the pointer can be nil messages. Here, we fix it to be more compliant with the go coding styleguide. Related: #280 * style: Fix staticcheck errors for "this value of X is never used (SA4006)" staticcheck is a static analysis tool for go. It report several "this value of X is never used (SA4006)" messages. Here, we fix it to be more compliant with the go coding styleguide. Related: #280
322 lines
9.6 KiB
Go
322 lines
9.6 KiB
Go
package jira
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"reflect"
|
|
"testing"
|
|
)
|
|
|
|
func TestAuthenticationService_AcquireSessionCookie_Failure(t *testing.T) {
|
|
setup()
|
|
defer teardown()
|
|
testMux.HandleFunc("/rest/auth/1/session", func(w http.ResponseWriter, r *http.Request) {
|
|
testMethod(t, r, "POST")
|
|
testRequestURL(t, r, "/rest/auth/1/session")
|
|
b, err := ioutil.ReadAll(r.Body)
|
|
if err != nil {
|
|
t.Errorf("Error in read body: %s", err)
|
|
}
|
|
if !bytes.Contains(b, []byte(`"username":"foo"`)) {
|
|
t.Error("No username found")
|
|
}
|
|
if !bytes.Contains(b, []byte(`"password":"bar"`)) {
|
|
t.Error("No password found")
|
|
}
|
|
|
|
// Emulate error
|
|
w.WriteHeader(http.StatusInternalServerError)
|
|
})
|
|
|
|
res, err := testClient.Authentication.AcquireSessionCookie("foo", "bar")
|
|
if err == nil {
|
|
t.Errorf("Expected error, but no error given")
|
|
}
|
|
if res == true {
|
|
t.Error("Expected error, but result was true")
|
|
}
|
|
|
|
if testClient.Authentication.Authenticated() != false {
|
|
t.Error("Expected false, but result was true")
|
|
}
|
|
}
|
|
|
|
func TestAuthenticationService_AcquireSessionCookie_Success(t *testing.T) {
|
|
setup()
|
|
defer teardown()
|
|
testMux.HandleFunc("/rest/auth/1/session", func(w http.ResponseWriter, r *http.Request) {
|
|
testMethod(t, r, "POST")
|
|
testRequestURL(t, r, "/rest/auth/1/session")
|
|
b, err := ioutil.ReadAll(r.Body)
|
|
if err != nil {
|
|
t.Errorf("Error in read body: %s", err)
|
|
}
|
|
if !bytes.Contains(b, []byte(`"username":"foo"`)) {
|
|
t.Error("No username found")
|
|
}
|
|
if !bytes.Contains(b, []byte(`"password":"bar"`)) {
|
|
t.Error("No password found")
|
|
}
|
|
|
|
fmt.Fprint(w, `{"session":{"name":"JSESSIONID","value":"12345678901234567890"},"loginInfo":{"failedLoginCount":10,"loginCount":127,"lastFailedLoginTime":"2016-03-16T04:22:35.386+0000","previousLoginTime":"2016-03-16T04:22:35.386+0000"}}`)
|
|
})
|
|
|
|
res, err := testClient.Authentication.AcquireSessionCookie("foo", "bar")
|
|
if err != nil {
|
|
t.Errorf("No error expected. Got %s", err)
|
|
}
|
|
if res == false {
|
|
t.Error("Expected result was true. Got false")
|
|
}
|
|
|
|
if testClient.Authentication.Authenticated() != true {
|
|
t.Error("Expected true, but result was false")
|
|
}
|
|
|
|
if testClient.Authentication.authType != authTypeSession {
|
|
t.Errorf("Expected authType %d. Got %d", authTypeSession, testClient.Authentication.authType)
|
|
}
|
|
}
|
|
|
|
func TestAuthenticationService_SetBasicAuth(t *testing.T) {
|
|
setup()
|
|
defer teardown()
|
|
|
|
testClient.Authentication.SetBasicAuth("test-user", "test-password")
|
|
|
|
if testClient.Authentication.username != "test-user" {
|
|
t.Errorf("Expected username test-user. Got %s", testClient.Authentication.username)
|
|
}
|
|
|
|
if testClient.Authentication.password != "test-password" {
|
|
t.Errorf("Expected password test-password. Got %s", testClient.Authentication.password)
|
|
}
|
|
|
|
if testClient.Authentication.authType != authTypeBasic {
|
|
t.Errorf("Expected authType %d. Got %d", authTypeBasic, testClient.Authentication.authType)
|
|
}
|
|
}
|
|
|
|
func TestAuthenticationService_Authenticated(t *testing.T) {
|
|
// Skip setup() because we don't want a fully setup client
|
|
testClient = new(Client)
|
|
|
|
// Test before we've attempted to authenticate
|
|
if testClient.Authentication.Authenticated() != false {
|
|
t.Error("Expected false, but result was true")
|
|
}
|
|
}
|
|
|
|
func TestAuthenticationService_Authenticated_WithBasicAuth(t *testing.T) {
|
|
setup()
|
|
defer teardown()
|
|
|
|
testClient.Authentication.SetBasicAuth("test-user", "test-password")
|
|
|
|
// Test before we've attempted to authenticate
|
|
if testClient.Authentication.Authenticated() != true {
|
|
t.Error("Expected true, but result was false")
|
|
}
|
|
}
|
|
|
|
func TestAuthenticationService_Authenticated_WithBasicAuthButNoUsername(t *testing.T) {
|
|
setup()
|
|
defer teardown()
|
|
|
|
testClient.Authentication.SetBasicAuth("", "test-password")
|
|
|
|
// Test before we've attempted to authenticate
|
|
if testClient.Authentication.Authenticated() != false {
|
|
t.Error("Expected false, but result was true")
|
|
}
|
|
}
|
|
|
|
func TestAithenticationService_GetUserInfo_AccessForbidden_Fail(t *testing.T) {
|
|
setup()
|
|
defer teardown()
|
|
testMux.HandleFunc("/rest/auth/1/session", func(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method == "POST" {
|
|
testMethod(t, r, "POST")
|
|
testRequestURL(t, r, "/rest/auth/1/session")
|
|
b, err := ioutil.ReadAll(r.Body)
|
|
if err != nil {
|
|
t.Errorf("Error in read body: %s", err)
|
|
}
|
|
if !bytes.Contains(b, []byte(`"username":"foo"`)) {
|
|
t.Error("No username found")
|
|
}
|
|
if !bytes.Contains(b, []byte(`"password":"bar"`)) {
|
|
t.Error("No password found")
|
|
}
|
|
|
|
fmt.Fprint(w, `{"session":{"name":"JSESSIONID","value":"12345678901234567890"},"loginInfo":{"failedLoginCount":10,"loginCount":127,"lastFailedLoginTime":"2016-03-16T04:22:35.386+0000","previousLoginTime":"2016-03-16T04:22:35.386+0000"}}`)
|
|
}
|
|
|
|
if r.Method == "GET" {
|
|
testMethod(t, r, "GET")
|
|
testRequestURL(t, r, "/rest/auth/1/session")
|
|
|
|
w.WriteHeader(http.StatusForbidden)
|
|
}
|
|
})
|
|
|
|
testClient.Authentication.AcquireSessionCookie("foo", "bar")
|
|
|
|
_, err := testClient.Authentication.GetCurrentUser()
|
|
if err == nil {
|
|
t.Errorf("Non nil error expect, received nil")
|
|
}
|
|
}
|
|
|
|
func TestAuthenticationService_GetUserInfo_NonOkStatusCode_Fail(t *testing.T) {
|
|
setup()
|
|
defer teardown()
|
|
|
|
testMux.HandleFunc("/rest/auth/1/session", func(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method == "POST" {
|
|
testMethod(t, r, "POST")
|
|
testRequestURL(t, r, "/rest/auth/1/session")
|
|
b, err := ioutil.ReadAll(r.Body)
|
|
if err != nil {
|
|
t.Errorf("Error in read body: %s", err)
|
|
}
|
|
if !bytes.Contains(b, []byte(`"username":"foo"`)) {
|
|
t.Error("No username found")
|
|
}
|
|
if !bytes.Contains(b, []byte(`"password":"bar"`)) {
|
|
t.Error("No password found")
|
|
}
|
|
|
|
fmt.Fprint(w, `{"session":{"name":"JSESSIONID","value":"12345678901234567890"},"loginInfo":{"failedLoginCount":10,"loginCount":127,"lastFailedLoginTime":"2016-03-16T04:22:35.386+0000","previousLoginTime":"2016-03-16T04:22:35.386+0000"}}`)
|
|
}
|
|
|
|
if r.Method == "GET" {
|
|
testMethod(t, r, "GET")
|
|
testRequestURL(t, r, "/rest/auth/1/session")
|
|
//any status but 200
|
|
w.WriteHeader(240)
|
|
}
|
|
})
|
|
|
|
testClient.Authentication.AcquireSessionCookie("foo", "bar")
|
|
|
|
_, err := testClient.Authentication.GetCurrentUser()
|
|
if err == nil {
|
|
t.Errorf("Non nil error expect, received nil")
|
|
}
|
|
}
|
|
|
|
func TestAuthenticationService_GetUserInfo_FailWithoutLogin(t *testing.T) {
|
|
// no setup() required here
|
|
testClient = new(Client)
|
|
|
|
_, err := testClient.Authentication.GetCurrentUser()
|
|
if err == nil {
|
|
t.Errorf("Expected error, but got %s", err)
|
|
}
|
|
}
|
|
|
|
func TestAuthenticationService_GetUserInfo_Success(t *testing.T) {
|
|
setup()
|
|
defer teardown()
|
|
|
|
testUserInfo := new(Session)
|
|
testUserInfo.Name = "foo"
|
|
testUserInfo.Self = "https://my.jira.com/rest/api/latest/user?username=foo"
|
|
testUserInfo.LoginInfo.FailedLoginCount = 12
|
|
testUserInfo.LoginInfo.LastFailedLoginTime = "2016-09-06T16:41:23.949+0200"
|
|
testUserInfo.LoginInfo.LoginCount = 357
|
|
testUserInfo.LoginInfo.PreviousLoginTime = "2016-09-07T11:36:23.476+0200"
|
|
|
|
testMux.HandleFunc("/rest/auth/1/session", func(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method == "POST" {
|
|
testMethod(t, r, "POST")
|
|
testRequestURL(t, r, "/rest/auth/1/session")
|
|
b, err := ioutil.ReadAll(r.Body)
|
|
if err != nil {
|
|
t.Errorf("Error in read body: %s", err)
|
|
}
|
|
if !bytes.Contains(b, []byte(`"username":"foo"`)) {
|
|
t.Error("No username found")
|
|
}
|
|
if !bytes.Contains(b, []byte(`"password":"bar"`)) {
|
|
t.Error("No password found")
|
|
}
|
|
|
|
fmt.Fprint(w, `{"session":{"name":"JSESSIONID","value":"12345678901234567890"},"loginInfo":{"failedLoginCount":10,"loginCount":127,"lastFailedLoginTime":"2016-03-16T04:22:35.386+0000","previousLoginTime":"2016-03-16T04:22:35.386+0000"}}`)
|
|
}
|
|
|
|
if r.Method == "GET" {
|
|
testMethod(t, r, "GET")
|
|
testRequestURL(t, r, "/rest/auth/1/session")
|
|
fmt.Fprint(w, `{"self":"https://my.jira.com/rest/api/latest/user?username=foo","name":"foo","loginInfo":{"failedLoginCount":12,"loginCount":357,"lastFailedLoginTime":"2016-09-06T16:41:23.949+0200","previousLoginTime":"2016-09-07T11:36:23.476+0200"}}`)
|
|
}
|
|
})
|
|
|
|
testClient.Authentication.AcquireSessionCookie("foo", "bar")
|
|
|
|
userinfo, err := testClient.Authentication.GetCurrentUser()
|
|
if err != nil {
|
|
t.Errorf("Nil error expect, received %s", err)
|
|
}
|
|
equal := reflect.DeepEqual(*testUserInfo, *userinfo)
|
|
|
|
if !equal {
|
|
t.Error("The user information doesn't match")
|
|
}
|
|
}
|
|
|
|
func TestAuthenticationService_Logout_Success(t *testing.T) {
|
|
setup()
|
|
defer teardown()
|
|
|
|
testMux.HandleFunc("/rest/auth/1/session", func(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method == "POST" {
|
|
testMethod(t, r, "POST")
|
|
testRequestURL(t, r, "/rest/auth/1/session")
|
|
b, err := ioutil.ReadAll(r.Body)
|
|
if err != nil {
|
|
t.Errorf("Error in read body: %s", err)
|
|
}
|
|
if !bytes.Contains(b, []byte(`"username":"foo"`)) {
|
|
t.Error("No username found")
|
|
}
|
|
if !bytes.Contains(b, []byte(`"password":"bar"`)) {
|
|
t.Error("No password found")
|
|
}
|
|
|
|
fmt.Fprint(w, `{"session":{"name":"JSESSIONID","value":"12345678901234567890"},"loginInfo":{"failedLoginCount":10,"loginCount":127,"lastFailedLoginTime":"2016-03-16T04:22:35.386+0000","previousLoginTime":"2016-03-16T04:22:35.386+0000"}}`)
|
|
}
|
|
|
|
if r.Method == "DELETE" {
|
|
// return 204
|
|
w.WriteHeader(http.StatusNoContent)
|
|
}
|
|
})
|
|
|
|
testClient.Authentication.AcquireSessionCookie("foo", "bar")
|
|
|
|
err := testClient.Authentication.Logout()
|
|
if err != nil {
|
|
t.Errorf("Expected nil error, got %s", err)
|
|
}
|
|
}
|
|
|
|
func TestAuthenticationService_Logout_FailWithoutLogin(t *testing.T) {
|
|
setup()
|
|
defer teardown()
|
|
|
|
testMux.HandleFunc("/rest/auth/1/session", func(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method == "DELETE" {
|
|
// 401
|
|
w.WriteHeader(http.StatusUnauthorized)
|
|
}
|
|
})
|
|
err := testClient.Authentication.Logout()
|
|
if err == nil {
|
|
t.Error("Expected not nil, got nil")
|
|
}
|
|
}
|