From abd72ba989943f559721c242f51a94e33a2569a1 Mon Sep 17 00:00:00 2001 From: shubhendra Date: Thu, 25 Feb 2021 14:30:58 +0530 Subject: [PATCH] Fix unnecessary calls to Printf --- .deepsource.toml | 12 ++++++++++++ metrics/generic/generic.go | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 .deepsource.toml diff --git a/.deepsource.toml b/.deepsource.toml new file mode 100644 index 0000000..f6c0dd8 --- /dev/null +++ b/.deepsource.toml @@ -0,0 +1,12 @@ +version = 1 + +test_patterns = ["**/*_test.go"] + +exclude_patterns = ["examples/**"] + +[[analyzers]] +name = "go" +enabled = true + + [analyzers.meta] + import_paths = ["github.com/go-kit/kit"] diff --git a/metrics/generic/generic.go b/metrics/generic/generic.go index b693345..39216c0 100644 --- a/metrics/generic/generic.go +++ b/metrics/generic/generic.go @@ -182,7 +182,7 @@ func (h *Histogram) LabelValues() []string { func (h *Histogram) Print(w io.Writer) { h.h.RLock() defer h.h.RUnlock() - fmt.Fprintf(w, h.h.String()) + fmt.Fprint(w, h.h.String()) } // safeHistogram exists as gohistogram.Histogram is not goroutine-safe.