go/go-micro
1
0
Fork 0
mirror of https://github.com/go-micro/go-micro.git synced 2025-08-04 21:42:57 +02:00
Code Issues Releases Activity

break config.Get and return error with value

Browse Source
This commit is contained in:
asim
2025-05-04 21:31:17 +01:00
parent 60474ed38f
commit 2388f662cf
9 changed files with 44 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
config/reader/json/json_test.go
View File

@ -36,7 +36,9 @@ func TestReader(t *testing.T) {
}
for _, test := range testData {
if v := values.Get(test.path...).String(""); v != test.value {
if v, err := values.Get(test.path...); err != nil {
t.Fatal(err)
} else if v.String("") != test.value {
t.Fatalf("Expected %s got %s for path %v", test.value, v, test.path)
}
}

4
config/reader/json/values.go
View File

@ -30,8 +30,8 @@ func newValues(ch *source.ChangeSet) (reader.Values, error) {
return &jsonValues{ch, sj}, nil
}
func (j *jsonValues) Get(path ...string) reader.Value {
return &jsonValue{j.sj.GetPath(path...)}
func (j *jsonValues) Get(path ...string) (reader.Value, error) {
return &jsonValue{j.sj.GetPath(path...)}, nil
}
func (j *jsonValues) Del(path ...string) {

12
config/reader/json/values_test.go
View File

@ -37,7 +37,11 @@ func TestValues(t *testing.T) {
t.Fatal(err)
}
err = values.Get(test.path...).Scan(&test.accepter)
v, err := values.Get(test.path...)
if err != nil {
t.Fatal(err)
}
err = v.Scan(&test.accepter)
if err != nil {
t.Fatal(err)
}
@ -74,7 +78,11 @@ func TestStructArray(t *testing.T) {
t.Fatal(err)
}
err = values.Get().Scan(&test.accepter)
v, err := values.Get()
if err != nil {
t.Fatal(err)
}
err = v.Scan(&test.accepter)
if err != nil {
t.Fatal(err)
}