fixing mem.pprof issue: (#2198)

parsing profile: concatenated profiles detected
fixing web service not start profile issue
fixing no default profile options issue

cmd/cmd.go

@@ -12,6 +12,8 @@ import (
 	"github.com/asim/go-micro/v3/client"
 	"github.com/asim/go-micro/v3/config"
 	"github.com/asim/go-micro/v3/debug/profile"
+	"github.com/asim/go-micro/v3/debug/profile/http"
+	"github.com/asim/go-micro/v3/debug/profile/pprof"
 	"github.com/asim/go-micro/v3/debug/trace"
 	"github.com/asim/go-micro/v3/logger"
 	"github.com/asim/go-micro/v3/registry"
@@ -257,7 +259,10 @@ var (
 
 	DefaultAuths = map[string]func(...auth.Option) auth.Auth{}
 
-	DefaultProfiles = map[string]func(...profile.Option) profile.Profile{}
+	DefaultProfiles = map[string]func(...profile.Option) profile.Profile{
+		"http":  http.NewProfile,
+		"pprof": pprof.NewProfile,
+	}
 
 	DefaultConfigs = map[string]func(...config.Option) (config.Config, error){}
 )

debug/profile/pprof/pprof.go

@@ -7,7 +7,6 @@ import (
 	"runtime"
 	"runtime/pprof"
 	"sync"
-	"time"
 
 	"github.com/asim/go-micro/v3/debug/profile"
 )
@@ -17,7 +16,6 @@ type profiler struct {
 
 	sync.Mutex
 	running bool
-	exit    chan bool
 
 	// where the cpu profile is written
 	cpuFile *os.File
@@ -25,23 +23,6 @@ type profiler struct {
 	memFile *os.File
 }
 
-func (p *profiler) writeHeap(f *os.File) {
-	defer f.Close()
-
-	t := time.NewTicker(time.Second * 30)
-	defer t.Stop()
-
-	for {
-		select {
-		case <-t.C:
-			runtime.GC()
-			pprof.WriteHeapProfile(f)
-		case <-p.exit:
-			return
-		}
-	}
-}
-
 func (p *profiler) Start() error {
 	p.Lock()
 	defer p.Unlock()
@@ -50,15 +31,12 @@ func (p *profiler) Start() error {
 		return nil
 	}
 
-	// create exit channel
+	cpuFile := filepath.Join(os.TempDir(), "cpu.pprof")
-	p.exit = make(chan bool)
+	memFile := filepath.Join(os.TempDir(), "mem.pprof")
-
-	cpuFile := filepath.Join("/tmp", "cpu.pprof")
-	memFile := filepath.Join("/tmp", "mem.pprof")
 
 	if len(p.opts.Name) > 0 {
-		cpuFile = filepath.Join("/tmp", p.opts.Name+".cpu.pprof")
+		cpuFile = filepath.Join(os.TempDir(), p.opts.Name+".cpu.pprof")
-		memFile = filepath.Join("/tmp", p.opts.Name+".mem.pprof")
+		memFile = filepath.Join(os.TempDir(), p.opts.Name+".mem.pprof")
 	}
 
 	f1, err := os.Create(cpuFile)
@@ -76,9 +54,6 @@ func (p *profiler) Start() error {
 		return err
 	}
 
-	// write the heap periodically
-	go p.writeHeap(f2)
-
 	// set cpu file
 	p.cpuFile = f1
 	// set mem file
@@ -93,19 +68,20 @@ func (p *profiler) Stop() error {
 	p.Lock()
 	defer p.Unlock()
 
-	select {
+	if !p.running {
-	case <-p.exit:
 		return nil
-	default:
+	}
-		close(p.exit)
+
 	pprof.StopCPUProfile()
 	p.cpuFile.Close()
+	runtime.GC()
+	pprof.WriteHeapProfile(p.memFile)
+	p.memFile.Close()
 	p.running = false
 	p.cpuFile = nil
 	p.memFile = nil
 	return nil
 }
-}
 
 func (p *profiler) String() string {
 	return "pprof"

web/service.go

@@ -8,6 +8,7 @@ import (
 	"os"
 	"os/signal"
 	"path/filepath"
+	"runtime"
 	"strings"
 	"sync"
 	"time"
@@ -445,6 +446,23 @@ func (s *service) Run() error {
 		return err
 	}
 
+	// start the profiler
+	if s.opts.Service.Options().Profile != nil {
+		// to view mutex contention
+		runtime.SetMutexProfileFraction(5)
+		// to view blocking profile
+		runtime.SetBlockProfileRate(1)
+
+		if err := s.opts.Service.Options().Profile.Start(); err != nil {
+			return err
+		}
+		defer func() {
+			if err := s.opts.Service.Options().Profile.Stop(); err != nil {
+				logger.Error(err)
+			}
+		}()
+	}
+
 	if err := s.register(); err != nil {
 		return err
 	}