go/go-micro
1
0
Fork 0
mirror of https://github.com/go-micro/go-micro.git synced 2024-12-24 10:07:04 +02:00
Code Issues Releases Activity

use sync.Once instead of chan

Browse Source 
sync.Once is more clear and faster than chan.
This commit is contained in:
Uffy 2017-10-09 15:47:28 +08:00
parent b92130eeee
commit ae3f59a2f5
1 changed files with 8 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
service.go
View File

@ -10,12 +10,13 @@ import (
"github.com/micro/go-micro/cmd" "github.com/micro/go-micro/cmd"
"github.com/micro/go-micro/metadata" "github.com/micro/go-micro/metadata"
"github.com/micro/go-micro/server" "github.com/micro/go-micro/server"
"sync"
) )
type service struct { type service struct {
opts Options opts Options
init chan bool once sync.Once
} }
func newService(opts ...Option) Service { func newService(opts ...Option) Service {
@ -30,7 +31,6 @@ func newService(opts ...Option) Service {
return &service{ return &service{
opts: options, opts: options,
init: make(chan bool),
} }
} }
@ -56,23 +56,12 @@ func (s *service) run(exit chan bool) {
// which parses command line flags. cmd.Init is only called // which parses command line flags. cmd.Init is only called
// on first Init. // on first Init.
func (s *service) Init(opts ...Option) { func (s *service) Init(opts ...Option) {
// If <-s.init blocks, Init has not been called yet // process options
// so we can call cmd.Init once. for _, o := range opts {
select { o(&s.opts)
case <-s.init: }
// only process options
for _, o := range opts {
o(&s.opts)
}
default:
// close init
close(s.init)
// process options
for _, o := range opts {
o(&s.opts)
}
s.once.Do(func() {
// Initialise the command flags, overriding new service // Initialise the command flags, overriding new service
s.opts.Cmd.Init( s.opts.Cmd.Init(
cmd.Broker(&s.opts.Broker), cmd.Broker(&s.opts.Broker),
@ -81,7 +70,7 @@ func (s *service) Init(opts ...Option) {
cmd.Client(&s.opts.Client), cmd.Client(&s.opts.Client),
cmd.Server(&s.opts.Server), cmd.Server(&s.opts.Server),
) )
} })
} }
func (s *service) Options() Options { func (s *service) Options() Options {